fix: update configmap deletion checks to use wildcard matching and add bash shell support in test scripts#584
Open
moshevayner wants to merge 3 commits into
Open
fix: update configmap deletion checks to use wildcard matching and add bash shell support in test scripts#584moshevayner wants to merge 3 commits into
moshevayner wants to merge 3 commits into
Conversation
…d bash shell support in test scripts Signed-off-by: Moshe Vayner <moshe@vayner.me>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
=======================================
Coverage 73.65% 73.65%
=======================================
Files 19 19
Lines 3029 3029
=======================================
Hits 2231 2231
Misses 538 538
Partials 260 260 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…d resources This will reduce some of the noisy errors in the test logs about not being able to delete something that was already removed. Signed-off-by: Moshe Vayner <moshe@vayner.me>
…-test.yaml Right now the test has a race condition because it tries to validate the loadbalancer before it has an IP assigned. This should fix it. Signed-off-by: Moshe Vayner <moshe@vayner.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Moshe Vayner moshe@vayner.me
General:
Pull Request Guidelines: