feat: adopt iOS SDK 0.0.11 (clickTokenSource 'none') - #5
Merged
Conversation
- Bump podspec dependency LinkTrailSDK ~> 0.0.10 -> ~> 0.0.11 - Add 'none' clickTokenSource (iOS): SDK never touches the clipboard, deferred matching falls back to probabilistic IP matching - Map 'none' -> LinkTrailClickTokenSource.none in the Swift bridge - Bump wrapper version to 0.0.4; update README + CHANGELOG
The committed lockfile pinned LinkTrailSDK = 0.0.10, so the CI 'pod install --repo-update' hit an unsatisfiable constraint against the podspec's new ~> 0.0.11 (--repo-update refreshes the spec repo but won't upgrade an already-locked pod). Regenerate the lock at 0.0.11 and sync the example package-lock's root reference to 0.0.4.
The retry for-loop exited 0 even when all attempts failed (last command was 'sleep 5'), so a failed pod install let xcodebuild run against a missing Pods/ dir. Exit 0 on success, exit 1 after 3 failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the LinkTrail iOS SDK 0.0.11 release.
What's in this release
LinkTrailSDK ~> 0.0.11(from0.0.10) in the podspec.clickTokenSource: 'none'mode (iOS) — the SDK never touches the clipboard (no paste button, no "Allow Paste" alert); deferred matching falls back to probabilistic IP matching only. Purely additive alongside the existing'pasteButton'(default) and'automatic'modes.'none'→LinkTrailClickTokenSource.none.example/ios/Podfile.lockatLinkTrailSDK 0.0.11(the committed lock pinned= 0.0.10, which conflicted with the new~> 0.0.11;pod install --repo-updaterefreshes the spec repo but won't upgrade an already-locked pod).0.0.11 is a non-breaking, additive release (iOS 15+). Android is unaffected.
Verification
All CI green, including the iOS simulator build — which compiles the Swift
.nonechange against the real 0.0.11 SDK.tsctypecheck passes.Follow-up (not in this PR)
.github/workflows/ios.ymlhas a latent bug: thepod installretryforloop exits0even when all 3 attempts fail (last command in the loop body issleep 5), so a failed pod install doesn't fail the step andxcodebuildthen runs against a missingPods/dir. Worth hardening (e.g.exit 1after the loop). Left out here because it needs a separate commit withworkflowscope.