fix: Android deferred deep linking + bump Android SDK to 0.0.5 - #4
Merged
Conversation
- Android native SDK -> io.linktrail:sdk:0.0.5; wrapper 0.0.3 - Example: autoTrackInstall is platform-aware — Android auto-tracks so deferred attribution resolves (no paste button there); iOS waits for the paste tap - Example: fix simulator "route after dismiss" (the timer was cancelled before it fired, so tapping a scenario never navigated on either platform) - Example: pnpm node-linker=hoisted so RN's Gradle plugin path resolves - Example: release signing read from local.properties + android:aab/apk/clean scripts - CHANGELOG: add 0.0.3, backfill 0.0.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android deferred deep linking fix
The example configured
autoTrackInstall: falseglobally (for the iOS paste-button flow). On Android there's no paste button, so nothing ever triggered the install, and the SDK'ssetConsent(true)only fires the install whenautoTrackInstallis true — so no install was sent and the backend never resolved the deferred link. NowautoTrackInstallis platform-aware: Android auto-tracks (deferred resolves via the Play Install Referrer), iOS still waits for the paste tap. The wrapper itself was fine — real RN Android apps use the defaultautoTrackInstall: true.Also in this PR
io.linktrail:sdk:0.0.5(from0.0.4); wrapper package →0.0.3.example/.npmrcwithnode-linker=hoistedso RN's Gradle plugin path (../node_modules/@react-native/gradle-plugin) resolves —pnpm androidwas failing without it.local.properties(gitignored) +android:aab/android:apk/android:cleanscripts.0.0.3, back-filled0.0.2.Verified
tscpasses; AndroidassembleDebugbuilds an APK resolvingio.linktrail:sdk:0.0.5.Note
The example now uses pnpm (
.npmrc+pnpm-lock.yaml), butexample/package-lock.jsonis still tracked — worth removing in a follow-up so there's one lockfile.