fix(js): preserve visible SVG text geometry on padded rows - #186
Merged
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ok 表run begins at column two and is not measured as a padded twelve-cell rowRoot cause and reproduction
Terminal buffers pad every row to their full width. The renderer coalesced that padding with adjacent default-style text and emitted the full padded width as SVG
textLength. Chromium disregards edge spaces when measuring the text, then stretches the visible glyphs to the full target width.Before the fix, the new regression produces:
After the fix, the same terminal frame produces:
A real 96×36 OpenCode frame from link-assistant/formal-ai#841 was also re-rendered and inspected in Chromium. Its
(no output)row is now an unstretched eleven-cell run (textLength="99") rather than a full-row run.Automated verification
bun test js/tests/terminal-capture.test.mjs --timeout 10000(10 passed)bun run lintbun run format:checkbun run check:duplicationbun scripts/validate-changeset.mjsbun test js/tests/ --timeout 10000: 751 passed, 10 skipped; 28 unrelated jq tests could not run because this local environment has nojqexecutableFixes #185