Add persistent MCTS export/import support#1211
Open
Zyxxx-xxxyZ wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an opt-in persistent MCTS mode that keeps search state across arbitrary root changes and can export/import the persistent MCTS state as JSON.
The key behavior is that useful ancestor-root search information can be inherited by a later descendant root, while searches performed inside a descendant subtree do not contaminate the ancestor's root-local result when switching back.
Approach
NodeStatsas a materialized cache. On root switches and import, rebuild the visible subtree from only the current root's tagged primitives.The proof sketch and invariants are documented in
docs/persistent-mcts.md.Tests
./build-persistent-mcts/katago runpersistentmctstests./build-persistent-mcts/katago runpersistentmctsstricttestsThe strict test runs deterministic SGF root-switch alignment against standard MCTS, including export/import reload checkpoints, and a stress pass. Local run summary: