Skip to content

fix(a11y): ISSUE_TEMPLATE README.md diagram YAML header block accTitle/accDescr#993

Closed
ashleyshaw wants to merge 3 commits into
developfrom
fix/issue-template-mermaid-accTitle
Closed

fix(a11y): ISSUE_TEMPLATE README.md diagram YAML header block accTitle/accDescr#993
ashleyshaw wants to merge 3 commits into
developfrom
fix/issue-template-mermaid-accTitle

Conversation

@ashleyshaw

Copy link
Copy Markdown
Member

Fix Pull Request

Linked issues

Closes #991

Summary

Adds the canonical YAML header block accTitle/accDescr to the Mermaid flowchart in .github/ISSUE_TEMPLATE/README.md, replacing the deprecated inline syntax that was missed during the Wave-5 Mermaid WCAG accessibility sweep.

Changes

  • .github/ISSUE_TEMPLATE/README.md: converts the flowchart accTitle/accDescr from inline declarations (inside the diagram body) to the YAML header block format (--- delimiters before the flowchart TD line), consistent with instructions/mermaid.instructions.md v2.0 and all other diagrams in the repository.

Impact / Compatibility

  • Runtime/behaviour changes: None — accessibility metadata only
  • CI: validate:mermaid-accessibility should pass

Verification

  • validate:mermaid-accessibility passes
  • validate:mermaid-syntax passes
  • Frontmatter version and last_updated bumped

Risk & Rollback

  • Risk level: Minimal — documentation-only change
  • Rollback plan: Revert commit

Changelog

Fixed


Checklist (Global DoD / PR)

  • All AC met and demonstrated
  • Tests added/updated (N/A — accessibility metadata only)
  • Accessibility checklist completed:
    • Semantic HTML and heading order verified
    • Keyboard navigation and visible focus states verified
    • ARIA used only where needed
    • Contrast and non-colour cues reviewed (WCAG 2.2 AA or higher)
  • Docs/readme/changelog updated
  • Security checklist completed:
    • No secrets/sensitive data introduced
  • CI green; linked issues closed

Generated by Claude Code

Signed-off-by: Ash Shaw <ashley@lightspeedwp.agency>
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 1caf5307-03b0-4e88-bdea-4f4b22ea6881

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-template-mermaid-accTitle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor

Metadata governance

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the Mermaid diagram in the issue template README by moving the accessibility attributes inside the flowchart block. The reviewer points out that this inline syntax violates the repository's guidelines, which require using a YAML header block with delimiters for accTitle and accDescr before the diagram type declaration, and provides a suggestion to correct this.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread .github/ISSUE_TEMPLATE/README.md Outdated
Comment on lines +49 to +52
flowchart TD
accTitle: Issue template workflow
accDescr: Shows how users select an issue template, auto-populated fields flow into issue creation, and automation routes the issue to labelling, project, and notification steps.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current implementation uses the inline syntax for accTitle and accDescr inside the diagram body, which violates the repository's Mermaid instructions. According to instructions/mermaid.instructions.md (lines 36-43 and 66-71), every Mermaid diagram must use the YAML header block format with --- delimiters placed immediately after the opening fence and before the diagram type declaration (e.g., flowchart TD).

Please update the diagram to use the correct YAML header block format.

Suggested change
flowchart TD
accTitle: Issue template workflow
accDescr: Shows how users select an issue template, auto-populated fields flow into issue creation, and automation routes the issue to labelling, project, and notification steps.
---
accTitle: Issue template workflow
accDescr: Shows how users select an issue template, auto-populated fields flow into issue creation, and automation routes the issue to labelling, project, and notification steps.
---
flowchart TD
References
  1. Every Mermaid block must include an accessibility header block placed immediately after the opening fence and before the diagram type declaration, using the --- delimiters. Inline attributes after the diagram type line are not allowed. (link)

claude added 2 commits June 18, 2026 17:50
… accTitle

Replaces deprecated inline accTitle/accDescr syntax (declared inside the
flowchart body) with the canonical YAML header block format required by
instructions/mermaid.instructions.md v2.0.

Addresses Gemini code review finding on PR #993.
Closes #991.
Required by validate:frontmatter:changed CI check — body changes must
be accompanied by a version bump and updated last_updated date.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AuT8NQeGYY9UQHLsX3MMHc

Copy link
Copy Markdown
Member Author

Closing this PR — the approach it implements (converting to YAML --- front-matter headers) turns out to be the wrong fix.

GitHub's embedded Mermaid renderer does not support YAML front-matter (--- blocks before the diagram type). Diagrams using that format show a parse error instead of rendering. The correct format keeps accTitle and accDescr as inline statements inside the diagram body, directly after the diagram type declaration.

This is superseded by branch fix/mermaid-inline-accessibility-syntax, which:

  • Fixes .github/ISSUE_TEMPLATE/README.md with the correct inline syntax
  • Converts all other YAML-header Mermaid diagrams across the entire repo to inline format
  • Updates scripts/validation/validate-mermaid-accessibility.js to reject YAML front-matter and give actionable errors
  • Updates instructions/mermaid.instructions.md and the Mermaid prompt to document the correct format

Issue #991 will be closed by the new PR.


Generated by Claude Code

@ashleyshaw ashleyshaw closed this Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(a11y): ISSUE_TEMPLATE README.md Mermaid diagram missing YAML header block accTitle/accDescr

2 participants