Require PHP 8.4 and use the new DOM API - #36
Merged
Merged
Conversation
The loader now uses Dom\XMLDocument and Dom\HTMLDocument. The method names and the exception contract do not change. The return types change, so this is a v4 major release.
XmlException::getPrevious() now returns the original DOMException.
The HTML5 parser recovers from malformed markup. loadHtml throws only for empty input, same as v3 in practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DOMDocument::loadXML/loadHTMLwithDom\XMLDocument::createFromStringandDom\HTMLDocument::createFromString.XmlLoader::loadXml(),XmlLoader::loadHtml(), andXmlExceptionwrappingLibXMLErrorstay the same.LIBXML_NONET | LIBXML_NOBLANKSfor XML, empty-input rejection, and DOCTYPE rejection.Breaking changes (v4)
loadXml()returnsDom\XMLDocumentandloadHtml()returnsDom\HTMLDocument. These classes do not extendDOMDocument.nodeValueon an element returnsnull; usetextContentinstead.loadHtml()parses with the HTML5 parser (Lexbor). The HTML5 parser recovers from malformed markup, soloadHtml()throws only on empty input or a hard parser failure. The old HTML 4 parser had almost the same failure behavior.Notes
LIBXML_NONETby itself. The loader still passes it explicitly.libxml_get_last_error(), soXmlException::getError()keeps line and column information.