multi: add labels for static addresses#1178
Open
GustavoStingelin wants to merge 6 commits into
Open
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Comment on lines
+134
to
+139
| // TODO: When multi-address support lands, resolve an existing address | ||
| // by label or create a new one when no matching label exists. | ||
| params := addresses[0] | ||
| clientPubKey := params.ClientPubkey | ||
| serverPubKey := params.ServerPubkey | ||
| expiry := int64(params.Expiry) |
Author
There was a problem hiding this comment.
Note: reviewers, pls, pay attention here.
GustavoStingelin
force-pushed
the
feat/static-address-label
branch
from
July 17, 2026 21:32
ae23a9d to
92270e0
Compare
Collaborator
|
I propose to include the current state of #1139 into this PR, so own label commits go after @hieblmi's commits. Add a note to the PR description not to review the multi-address commits. I attempted to do a rebase using AI, here is my attempt: https://github.com/starius/loop/commits/staticaddr-combined/ It is not functional. Some semantic rebase is needed. For example:
Found some issues in that multi-address + labels branch that I got:
Some of them will be resolved by a proper rebase, but some seem genuine. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds persistent, locally managed labels for static addresses.