staticaddr/loopin: keep refreshed deposits canonical#1176
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the reliability of the loop-in process by ensuring that selected deposits are always retrieved from the live, canonical state managed by the deposit manager. By moving away from potentially stale database snapshots, the system avoids incorrect state validation and prevents failures during timeout transitions. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the refreshSelectedDeposits function in staticaddr/loopin/actions.go to retrieve active deposits using the deposit manager's AllStringOutpointsActiveDeposits method instead of DepositsForOutpoints. This ensures that recovery relies on the deposit manager's active set rather than stale snapshots. The corresponding unit tests and the noopDepositManager mock in actions_test.go have been updated to reflect and verify this change. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
7d4483a to
440a3bc
Compare
Neutrino can remove a spent input from its wallet view while transaction publication is still blocked. This lets deposit reconciliation remove the deposit before the withdrawal manager marks it as withdrawing. Persist the finalized transaction and transition the deposits first. Roll the preparation back if publication fails.
1 participant
Use the deposit manager’s live deposit objects after wallet reconciliation instead of database
snapshots. This prevents stale state validation and repeated timeout transition failures.