fuzz: cover deferred writing in chanmon_consistency#4465
Draft
joostjager wants to merge 1 commit intolightningdevkit:mainfrom
Draft
fuzz: cover deferred writing in chanmon_consistency#4465joostjager wants to merge 1 commit intolightningdevkit:mainfrom
joostjager wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
👋 Hi! I see this is a draft PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4465 +/- ##
==========================================
- Coverage 87.00% 86.99% -0.02%
==========================================
Files 163 163
Lines 109002 109002
Branches 109002 109002
==========================================
- Hits 94839 94828 -11
- Misses 11678 11687 +9
- Partials 2485 2487 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joostjager
force-pushed
the
chain-mon-internal-deferred-writes-with-fuzz
branch
from
51afc25 to
0aebb10
Compare
Contributor
Author
|
Rebased |
Contributor
Author
joostjager
force-pushed
the
chain-mon-internal-deferred-writes-with-fuzz
branch
from
0aebb10 to
6274ba0
Compare
Contributor
Author
|
Prerequisites are in, rebased. |
Collaborator
|
This LGTM, why is it draft? |
Contributor
Author
|
I first wanted to do a serious local run, but then it turned out there are so many pre-existing fuzz failures that it is hard to see what's new. I've bisected the failures to the various PRs that introduced them. |
Contributor
Author
|
Although for this PR I could just see if anything pops up that doesnt repro on main. Will do that. |
Contributor
Author
|
Several newly introduced fuzz failures to address: |
Contributor
Author
|
Zoomed in on one of those sequences, and it seems it is reproducible with another string without deferred mode too. |
joostjager
force-pushed
the
chain-mon-internal-deferred-writes-with-fuzz
branch
from
6274ba0 to
c6da16e
Compare
Add a deferred flag to TestChainMonitor that controls whether the underlying ChainMonitor queues operations instead of executing them immediately. The flag is derived from the first fuzz input byte so each of the three nodes can independently run in deferred or immediate mode, while the same byte also selects the channel type. In deferred mode, watch_channel and update_channel always return InProgress. A new flush_and_update_latest_monitors method drains the queued operations and, when the persister reports Completed, promotes the pending shadow monitor snapshots to persisted state. This method is called before release_pending_monitor_events, at each point where the fuzzer completes pending monitor updates, and after watch_channel during node reload so the node starts from a consistent state. The first-byte config layout now uses bits 0 to 2 for initial monitor status, bits 3 to 4 for channel type, and bits 5 to 7 for deferred monitor writes. This fixes the rebase conflict where deferred mode still referenced the pre-channel-type bit layout. AI tools were used in preparing this commit.
joostjager
force-pushed
the
chain-mon-internal-deferred-writes-with-fuzz
branch
from
c6da16e to
d4bf3e0
Compare
Contributor
Author
|
Dependency: #4520 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds fuzz coverage for #4351