Skip to content

LSPS5 support on ldk-node#645

Closed
martinsaposnic wants to merge 1 commit into
lightningdevkit:mainfrom
martinsaposnic:lsps5
Closed

LSPS5 support on ldk-node#645
martinsaposnic wants to merge 1 commit into
lightningdevkit:mainfrom
martinsaposnic:lsps5

Conversation

@martinsaposnic

@martinsaposnic martinsaposnic commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@ldk-reviews-bot

ldk-reviews-bot commented Sep 22, 2025 •
edited
Loading

Copy link
Copy Markdown

👋 Hi! This PR is now in draft status.
I'll wait to assign reviewers until you mark it as ready for review.
Just convert it out of draft status when you're ready for review!

@martinsaposnic martinsaposnic force-pushed the lsps5 branch 2 times, most recently from 4d00cfb to 21f63a4 Compare September 22, 2025 20:49
@TheBlueMatt TheBlueMatt mentioned this pull request Sep 23, 2025
Open
@ldk-reviews-bot

ldk-reviews-bot commented Sep 24, 2025

Copy link
Copy Markdown

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull
tnull reviewed Sep 25, 2025
View reviewed changes

@tnull tnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will get back to this soon, but probably needs to be based on #650 intermittently.

@martinsaposnic

martinsaposnic commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

will wait until #650 is merged. converting to draft for now

@martinsaposnic martinsaposnic marked this pull request as draft September 30, 2025 05:36
@tnull tnull changed the base branch from develop to main October 7, 2025 08:52
@tnull

tnull commented Oct 7, 2025

Copy link
Copy Markdown
Collaborator

We decided to make the develop behavior (tracking more-recent LDK main) the default behavior. With #655 we merged develop into main and now deleted the develop branch. Hence the base branch is changed to main here, too.

@tnull

tnull commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

This needs a rebase now that #650 has been merged.

@tnull

tnull commented Nov 24, 2025

Copy link
Copy Markdown
Collaborator

@martinsaposnic Do you still intend to finish this PR?

@Camillarhi

Camillarhi commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

@martinsaposnic Do you still intend to finish this PR?

Hi @tnull, I spoke to @martinsaposnic elsewhere, and I’ll be picking this up.

@tnull

tnull commented Nov 25, 2025

Copy link
Copy Markdown
Collaborator

@martinsaposnic Do you still intend to finish this PR?

Hi @tnull, I spoke to @martinsaposnic elsewhere, and I’ll be picking this up.

Alright, sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnull tnull tnull left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@martinsaposnic @ldk-reviews-bot @tnull @Camillarhi