Skip to content

Make mnemonic RNG selection explicit #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnull merged 1 commit into from
Aug 5, 2026
+3 −2
Merged

Make mnemonic RNG selection explicit #1013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/entropy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

use std::fmt;

use bip39::Mnemonic;
use bip39::{rand::rngs::OsRng, Language, Mnemonic};

use crate::config::WALLET_KEYS_SEED_LEN;
use crate::io;
Expand Down Expand Up @@ -128,7 +128,8 @@ impl fmt::Debug for NodeEntropy {
/// [`Node`]: crate::Node
pub fn generate_entropy_mnemonic(word_count: Option<WordCount>) -> Mnemonic {
let word_count = word_count.unwrap_or(WordCount::Words24).word_count();
Mnemonic::generate(word_count).expect("Failed to generate mnemonic")
Mnemonic::generate_in_with(&mut OsRng, Language::English, word_count)
.expect("Failed to generate mnemonic")
}

/// Supported BIP39 mnemonic word counts for entropy generation.
Expand Down
Loading