jp2ksave: prevent heap buffer overflow on non-RGB images#5030
Open
dloebl wants to merge 3 commits intolibvips:8.18from
Open
jp2ksave: prevent heap buffer overflow on non-RGB images#5030dloebl wants to merge 3 commits intolibvips:8.18from
dloebl wants to merge 3 commits intolibvips:8.18from
Conversation
0e43bca to
7eaec98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #5020, there is an OOB read/write (heap buffer overflow) in the
save_as_yccpath if the input image isn't RGB. TheBands == 3check that is already present invips__foreign_save_jp2k_compresshas to be applied to the regularjp2ksavebuild as well:libvips/libvips/foreign/jp2ksave.c
Line 1338 in 9bde113
Reproducer: