Skip to content

Fix 743 #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjaeckel merged 2 commits into from
Apr 27, 2026
Merged

Fix 743 #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
876460e
Add testcases.
sjaeckel Apr 27, 2026
1bb1e61
Fix off-by-one heap BOF.
tynus3 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pk/asn1/der/general/der_decode_asn1_identifier.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ int der_decode_asn1_identifier(const unsigned char *in, unsigned long *inlen, lt
if (id->tag == 0x1f) {
id->tag = 0;
do {
if (*inlen < tag_len) {
if (*inlen <= tag_len) {
/* break the loop and trigger the BOF error-code */
tmp = 0xff;
break;
Expand Down
38 changes: 35 additions & 3 deletions tests/der_test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1037,14 +1037,20 @@ static void der_Xcode_test(void)
ltc_mp_clear(mpinteger);
}

#ifdef LTC_TEST_READDIR
static int s_der_decode_sequence_flexi(const void *in, unsigned long inlen, void* ctx)
{
int err;
ltc_asn1_list** list = ctx;
if (der_decode_sequence_flexi(in, &inlen, list) == CRYPT_OK) {
if ((err = der_decode_sequence_flexi(in, &inlen, list)) == CRYPT_OK) {
s_der_tests_print_flexi(*list);
der_sequence_free(*list);
}
return err;
}
#ifdef LTC_TEST_READDIR
static int s_der_decode_sequence_flexi_always_OK(const void *in, unsigned long inlen, void* ctx)
{
s_der_decode_sequence_flexi(in, inlen, ctx);
return CRYPT_OK;
}
#endif
Expand Down Expand Up @@ -1291,6 +1297,30 @@ static void s_der_recursion_limit(void)
}
}

static void s_der_issue743(void)
{
const unsigned char tests_asn1_0x028101FF_der[] = {
0x02, 0x81, 0x01, 0xff
};
const unsigned char tests_asn1_0x0500FF_der[] = {
0x05, 0x00, 0xff
};
const struct {
const unsigned char *d;
unsigned long l;
} test_cases[] = {
#define TEST_CASE(n) { n, sizeof(n) }
TEST_CASE(tests_asn1_0x028101FF_der),
TEST_CASE(tests_asn1_0x0500FF_der),
#undef TEST_CASE
};
unsigned long n;
ltc_asn1_list *asn1 = NULL;
for (n = 0; n < LTC_ARRAY_SIZE(test_cases); ++n) {
SHOULD_FAIL(s_der_decode_sequence_flexi(test_cases[n].d, test_cases[n].l, &asn1));
}
}

int der_test(void)
{
unsigned long x, y, z, zz, oid[2][32];
Expand Down Expand Up @@ -1332,12 +1362,14 @@ int der_test(void)

if (ltc_mp.name == NULL) return CRYPT_NOP;

s_der_issue743();

s_der_recursion_limit();

der_Xcode_test();

#ifdef LTC_TEST_READDIR
DO(test_process_dir("tests/asn1", &list, s_der_decode_sequence_flexi, NULL, NULL, "DER ASN.1 special cases"));
DO(test_process_dir("tests/asn1", &list, s_der_decode_sequence_flexi_always_OK, NULL, NULL, "DER ASN.1 special cases"));
#endif

der_custom_test();
Expand Down
Loading