Knuth bendix search#453
Closed
james-d-mitchell wants to merge 2 commits into
Closed
Conversation
james-d-mitchell
added
the
libsemigroups-feature-not-yet-supported
james-d-mitchell
force-pushed
the
knuth-bendix-search
branch
from
7410f3e to
d2a53d7
Compare
co-authored-by: Codex OpenAI <codex@openai.com>
james-d-mitchell
force-pushed
the
knuth-bendix-search
branch
from
d2a53d7 to
fcd61f2
Compare
Member
Author
|
TODO:
both of these require changes to libsemigroups itself first. |
Member
Author
Joseph-Edwards
left a comment
Joseph-Edwards
left a comment
Collaborator
There was a problem hiding this comment.
Other than a comment about type hints, I think this is good to go. Thanks @james-d-mitchell
| }, | ||
| py::arg("val"), | ||
| R"pbdoc( | ||
| :sig=(self: TietzeExplorer, val: SupportsInt | SupportsIndex) -> TietzeExplorer: |
Collaborator
There was a problem hiding this comment.
I think we decided on using int instead of SupportsInt | SupportsIndex.
Member
Author
|
We decided to go in a different direction in libsemigroups itself, so the changes in this PR are no longer required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.