Skip to content

Replace throws -> raises#423

Merged
Joseph-Edwards merged 3 commits into
libsemigroups:stable-1.4from
james-d-mitchell:throws-becomes-raises
May 5, 2026
Merged

Replace throws -> raises#423
Joseph-Edwards merged 3 commits into
libsemigroups:stable-1.4from
james-d-mitchell:throws-becomes-raises

Conversation

@james-d-mitchell
Copy link
Copy Markdown
Member

No description provided.

@james-d-mitchell james-d-mitchell mentioned this pull request Apr 30, 2026
Copy link
Copy Markdown
Collaborator

@Joseph-Edwards Joseph-Edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, though there are some more examples of "throws" in forest.cpp and present.cpp. If we could make the same changes in these files, then I would be happy to merge. Thanks @james-d-mitchell!

@james-d-mitchell james-d-mitchell force-pushed the throws-becomes-raises branch from 9788669 to 9a01ece Compare May 2, 2026 08:11
@james-d-mitchell james-d-mitchell force-pushed the throws-becomes-raises branch from a64b67e to 8724ed1 Compare May 5, 2026 10:58
@james-d-mitchell
Copy link
Copy Markdown
Member Author

Done, okay to merge @Joseph-Edwards

@Joseph-Edwards
Copy link
Copy Markdown
Collaborator

I've just spotted some more (and not sure how I didn't see these earlier, sorry!):

> rg throws
docs/source/data-structures/presentations/to-present.rst
75:This function throws a :any:`LibsemigroupsError` if the type of words in *p* is
77:``p.throw_if_bad_alphabet_or_rules()`` throws.
131:This function throws a :any:`LibsemigroupsError` if
132:``p.throw_if_bad_alphabet_or_rules()`` throws, or if the function specified by

docs/source/data-structures/presentations/to-inverse-present.rst
56:This function throws a :any:`LibsemigroupsError` if
57:``p.throw_if_bad_alphabet_or_rules()`` throws.
122:This function throws a :any:`LibsemigroupsError` if the type of words in *ip* is
124:``p.throw_if_bad_alphabet_rules_or_inverses()`` throws.
180:This function throws a :any:`LibsemigroupsError` if
181:``ip.throw_if_bad_alphabet_rules_or_inverses()`` throws, or if the function

docs/source/main-algorithms/froidure-pin/to-froidure-pin.rst
55:This function throws a :any:`LibsemigroupsError` if ``cong.kind`` is not
98:This function throws a :any:`LibsemigroupsError` if the
148:This function throws a :any:`LibsemigroupsError` if ``kb.kind()`` is not
192:This function throws a :any:`LibsemigroupsError` if ``tc.kind()`` is not
260:This function throws a :any:`LibsemigroupsError` if
261:``throw_if_image_value_out_of_range`` throws for any of the constructed

After those, we can merge

@james-d-mitchell
Copy link
Copy Markdown
Member Author

I've just spotted some more (and not sure how I didn't see these earlier, sorry!):

> rg throws
docs/source/data-structures/presentations/to-present.rst
75:This function throws a :any:`LibsemigroupsError` if the type of words in *p* is
77:``p.throw_if_bad_alphabet_or_rules()`` throws.
131:This function throws a :any:`LibsemigroupsError` if
132:``p.throw_if_bad_alphabet_or_rules()`` throws, or if the function specified by

docs/source/data-structures/presentations/to-inverse-present.rst
56:This function throws a :any:`LibsemigroupsError` if
57:``p.throw_if_bad_alphabet_or_rules()`` throws.
122:This function throws a :any:`LibsemigroupsError` if the type of words in *ip* is
124:``p.throw_if_bad_alphabet_rules_or_inverses()`` throws.
180:This function throws a :any:`LibsemigroupsError` if
181:``ip.throw_if_bad_alphabet_rules_or_inverses()`` throws, or if the function

docs/source/main-algorithms/froidure-pin/to-froidure-pin.rst
55:This function throws a :any:`LibsemigroupsError` if ``cong.kind`` is not
98:This function throws a :any:`LibsemigroupsError` if the
148:This function throws a :any:`LibsemigroupsError` if ``kb.kind()`` is not
192:This function throws a :any:`LibsemigroupsError` if ``tc.kind()`` is not
260:This function throws a :any:`LibsemigroupsError` if
261:``throw_if_image_value_out_of_range`` throws for any of the constructed

After those, we can merge

No worries, at all, I've fixed those too now, probably best to squash, when merging.

@james-d-mitchell james-d-mitchell force-pushed the throws-becomes-raises branch from d999d34 to a656c9e Compare May 5, 2026 11:26
@Joseph-Edwards Joseph-Edwards merged commit a6f63e6 into libsemigroups:stable-1.4 May 5, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants