Skip to content

Update vs props for local build options. #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 4 commits into from
Jul 19, 2026
+22 −12
Merged

Update vs props for local build options. #1084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c82281
Avoid OptionInfo name conflict.
evoskuil Jul 19, 2026
84af097
Set vs .props Option-sha/ssl defaults only if not set.
evoskuil Jul 19, 2026
879092e
Integrate Option-arch into Release and Messages.
evoskuil Jul 19, 2026
ea1d7b8
Map vs props Option-arch to name (for proper display).
evoskuil Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions builds/msvc/properties/Messages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<Message Text="ConfigurationType : $(ConfigurationType)" Importance="high"/>
<Message Text="Configuration : $(Configuration)" Importance="high"/>
<Message Text="Processor : $(ProcessorArchitecture)" Importance="high"/>
<Message Text="Architecture : $(Option-arch)" Importance="high"/>
<Message Text="TargetPath : $(TargetPath)" Importance="high"/>
</Target>

Expand Down
17 changes: 13 additions & 4 deletions builds/msvc/properties/Release.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@
<DebugOrRelease>Release</DebugOrRelease>
<!--<LinkIncremental>false</LinkIncremental>-->
</PropertyGroup>

<!-- Overridable per machine (e.g. Directory.Build.props above repos, or environment). -->
<PropertyGroup>
<Option-arch Condition="'$(Option-arch)' == ''">AdvancedVectorExtensions2</Option-arch>
</PropertyGroup>

<!-- DebugInformationFormat and GenerateDebugInformation were formerly disabled. -->
<!-- This is why we were not getting symbols in release builds (update nuget). -->
Expand All @@ -29,10 +34,14 @@
<OmitFramePointers>true</OmitFramePointers>
<Optimization>MaxSpeed</Optimization>

<!-- SSE4/AVX2 (also AVX512) -->
<!--TODO: these should be integrated with the HAVE build options.-->
<!--<EnableEnhancedInstructionSet>StreamingSIMDExtensions2</EnableEnhancedInstructionSet>-->
<EnableEnhancedInstructionSet>AdvancedVectorExtensions2</EnableEnhancedInstructionSet>
<!-- Literal (not macro) values retain property page presentation text. -->
<EnableEnhancedInstructionSet Condition="'$(Option-arch)' == 'NotSet'">NotSet</EnableEnhancedInstructionSet>
<EnableEnhancedInstructionSet Condition="'$(Option-arch)' == 'NoExtensions'">NoExtensions</EnableEnhancedInstructionSet>
<EnableEnhancedInstructionSet Condition="'$(Option-arch)' == 'StreamingSIMDExtensions'">StreamingSIMDExtensions</EnableEnhancedInstructionSet>
<EnableEnhancedInstructionSet Condition="'$(Option-arch)' == 'StreamingSIMDExtensions2'">StreamingSIMDExtensions2</EnableEnhancedInstructionSet>
<EnableEnhancedInstructionSet Condition="'$(Option-arch)' == 'AdvancedVectorExtensions'">AdvancedVectorExtensions</EnableEnhancedInstructionSet>
<EnableEnhancedInstructionSet Condition="'$(Option-arch)' == 'AdvancedVectorExtensions2'">AdvancedVectorExtensions2</EnableEnhancedInstructionSet>
<EnableEnhancedInstructionSet Condition="'$(Option-arch)' == 'AdvancedVectorExtensions512'">AdvancedVectorExtensions512</EnableEnhancedInstructionSet>

<!-- Other. -->
<DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
Expand Down
4 changes: 2 additions & 2 deletions builds/msvc/vs2022/libbitcoin-network.import.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
<!-- Options -->

<PropertyGroup>
<Option-ssl>true</Option-ssl>
<Option-ssl Condition="'$(Option-ssl)' == ''">true</Option-ssl>
</PropertyGroup>

<!-- Messages -->

<Target Name="OptionInfo" BeforeTargets="PrepareForBuild">
<Target Name="NetworkOptionInfo" BeforeTargets="PrepareForBuild">
<Message Text="Option-ssl : $(Option-ssl)" Importance="high"/>
</Target>

Expand Down
4 changes: 2 additions & 2 deletions builds/msvc/vs2022/libbitcoin-system.import.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<!--<Option-512>false</Option-512>-->
<!--<Option-256>true</Option-256>-->
<!--<Option-128>true</Option-128>-->
<Option-sha>false</Option-sha>
<Option-sha Condition="'$(Option-sha)' == ''">false</Option-sha>
</PropertyGroup>
<ItemDefinitionGroup>
<ClCompile>
Expand All @@ -34,7 +34,7 @@

<!-- Messages -->

<Target Name="OptionInfo" BeforeTargets="PrepareForBuild">
<Target Name="SystemOptionInfo" BeforeTargets="PrepareForBuild">
<Message Text="Option-sha : $(Option-sha)" Importance="high"/>
<!--<Message Text="Option-512 : $(Option-512)" Importance="high"/>-->
<!--<Message Text="Option-256 : $(Option-256)" Importance="high"/>-->
Expand Down
4 changes: 2 additions & 2 deletions builds/msvc/vs2026/libbitcoin-network.import.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
<!-- Options -->

<PropertyGroup>
<Option-ssl>true</Option-ssl>
<Option-ssl Condition="'$(Option-ssl)' == ''">true</Option-ssl>
</PropertyGroup>

<!-- Messages -->

<Target Name="OptionInfo" BeforeTargets="PrepareForBuild">
<Target Name="NetworkOptionInfo" BeforeTargets="PrepareForBuild">
<Message Text="Option-ssl : $(Option-ssl)" Importance="high"/>
</Target>

Expand Down
4 changes: 2 additions & 2 deletions builds/msvc/vs2026/libbitcoin-system.import.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<!--<Option-512>false</Option-512>-->
<!--<Option-256>true</Option-256>-->
<!--<Option-128>true</Option-128>-->
<Option-sha>false</Option-sha>
<Option-sha Condition="'$(Option-sha)' == ''">false</Option-sha>
</PropertyGroup>
<ItemDefinitionGroup>
<ClCompile>
Expand All @@ -34,7 +34,7 @@

<!-- Messages -->

<Target Name="OptionInfo" BeforeTargets="PrepareForBuild">
<Target Name="SystemOptionInfo" BeforeTargets="PrepareForBuild">
<Message Text="Option-sha : $(Option-sha)" Importance="high"/>
<!--<Message Text="Option-512 : $(Option-512)" Importance="high"/>-->
<!--<Message Text="Option-256 : $(Option-256)" Importance="high"/>-->
Expand Down
Loading