TLA2528 by SuksAE · Pull Request #5618 · letscontrolit/ESPEasy

SuksAE · 2026-08-22T15:19:12Z

Here is the pull request for the TLA2528 Plugin...

Thanks

tonhuisman · 2026-08-22T18:11:01Z

Please do not commit this file, it is included in .gitignore, but unfortunately not really ignored 😒

tonhuisman · 2026-08-22T18:16:06Z

+  |added|
+  Initial release version.


A date is missing here?

tonhuisman · 2026-08-22T18:25:18Z

+#define P188_CAL_RAW2_P1      PCONFIG_LONG(4)
+#define P188_CAL_RAW2_P2      PCONFIG_LONG(5)
+#define P188_CAL_RAW3_P1      PCONFIG_LONG(6)
+#define P188_CAL_RAW3_P2      PCONFIG_LONG(7)


There are only 4 PCONFIG_LONG available. This will overwrite the values for the next task (or be overwritten if the next task is saved). And it can't be extended as that will render all existing settings files incompatible.

tonhuisman · 2026-08-22T18:26:47Z

+#define P188_CAL_OUT2_P1      PCONFIG_FLOAT(4)
+#define P188_CAL_OUT2_P2      PCONFIG_FLOAT(5)
+#define P188_CAL_OUT3_P1      PCONFIG_FLOAT(6)
+#define P188_CAL_OUT3_P2      PCONFIG_FLOAT(7)


Ditto for PCONFIG_FLOAT.

tonhuisman · 2026-08-22T18:37:07Z

+      dev.Ports              = 0;                                // Port to use when device has multiple I/O pins  (N.B. not used much)
+      dev.ValueCount         = 4;                                // The number of output values of a plugin. The value should match the number of keys PLUGIN_VALUENAME1_xxx
+      dev.OutputDataType     = Output_Data_type_t::Simple;       // Subset of selectable output data types  (Default = no selection)
+      dev.PullUpOption       = false;                            // Allow to set internal pull-up resistors.
+      dev.InverseLogicOption = false;                            // Allow to invert the boolean state (e.g. a switch)
+      dev.FormulaOption      = true;                             // Allow to enter a formula to convert values during read. (not possible with Custom enabled)
+      dev.Custom             = false;
+      dev.SendDataOption     = true;                             // Allow to send data to a controller.
+      dev.GlobalSyncOption   = false;                            // No longer used. Was used for ESPeasy values sync between nodes
+      dev.TimerOption        = true;                             // Allow to set the "Interval" timer for the plugin.
+      dev.TimerOptional      = false;                            // When taskdevice timer is not set and not optional, use default "Interval" delay (Settings.Delay)
+      dev.DecimalsOnly       = false;                            // Allow to set the number of decimals (otherwise treated a 0 decimals)
+      dev.CustomVTypeVar     = true;                             // Enable to allow the user to configure the Sensor_VType per Value that's available for the plugin
+      dev.PluginStats        = true;                             // Support for PluginStats to record last N task values, show charts etc.
+      dev.MqttStateClass     = true;


Please leave out any = 0 and = false assignment, as that's already taken care of in the constructor of the Device structure.

tonhuisman · 2026-08-22T18:43:42Z

+#ifdef P188_FEATURE_RESISTOR_MEASUREMENT
+      tmp_config.R_Clip = 0.0f;
+#endif


This can be solved by an initializer in the struct.

tonhuisman · 2026-08-22T18:44:06Z

+#ifdef P188_FEATURE_RESISTOR_MEASUREMENT
+    uint32_t Rref[VARS_PER_TASK];
+    uint32_t Rpar[VARS_PER_TASK];
+#endif // P188_FEATURE_RESISTOR_MEASUREMENT


These variables can be reset initially by using the {} initializer on them, like float R_Clip{};

SuksAE · 2026-08-23T11:21:24Z

changed code and documentation - please review.
Thanks

tonhuisman · 2026-08-23T14:36:47Z

+      if ((P188_OUTPUT_MAPPING_0 > 11) || (P188_OUTPUT_MAPPING_1 > 11) || (P188_OUTPUT_MAPPING_2 > 11) || (P188_OUTPUT_MAPPING_3 > 11))
+      {


That magic number 11 should better be a #define or some enum value (also in the other places where it's used), this is very error-prone, and hard to comprehend.

tonhuisman · 2026-08-23T14:37:39Z

        addFormCheckBox(F("Enable Calibration"), getPluginCustomArgName(i * 8 + 3), ((P188_configBits.en_cal >> i) & 0x01));

-        addFormNumericBox(F("Point 1"), getPluginCustomArgName(i * 8 + 4), PCONFIG_LONG(P188_CAL_INDEX + 2*i), -32768, 32767);
+        addFormFloatNumberBox(F("Point 1"), getPluginCustomArgName(i * 8 + 4), tmp_config.CalIn[i][0], -1000000, 1000000, 2, 1.0f); 


The min and max arguments are also floats, that like the .0f suffix.

tonhuisman · 2026-08-23T14:38:56Z

-        const uint8_t pconfigIndex = P188_OUTPUT_MAPPING_OFFSET + i;
-        const uint8_t choice       = PCONFIG(pconfigIndex);
-        sensorTypeHelper_saveOutputSelector(event, pconfigIndex, i, Plugin_188_output_mapping_name(choice, false));
+      if ((P188_OUTPUT_MAPPING_0 > 11) || (P188_OUTPUT_MAPPING_1 > 11) || (P188_OUTPUT_MAPPING_2 > 11) || (P188_OUTPUT_MAPPING_3 > 11))


Same magic number

tonhuisman · 2026-08-23T14:39:29Z

 #ifdef P188_FEATURE_RESISTOR_MEASUREMENT
-        addFormNumericBox(F("Reference Resistor Value"), getPluginCustomArgName(i * 8 + 0), tmp_config.Rref[i], 100, 470000);
-        addFormNumericBox(F("Parallel Resistor Value"),  getPluginCustomArgName(i * 8 + 1), tmp_config.Rpar[i],   0, 470000);
+        if (PCONFIG(i + P188_OUTPUT_MAPPING_OFFSET) > 11)


Another one

This also needs another check to make sure the index for PCONFIG(...) is within range.

I will make a separate PR for adding checks for these macros for builds without BUILD_NO_DEBUG enabled, so we can have a runtime check on nodes with a bit more headroom to do some runtime checks to see if there are clear programming errors.

tonhuisman · 2026-08-23T14:39:57Z

 #ifdef P188_FEATURE_RESISTOR_MEASUREMENT
-        tmp_config.Rref[i] = getFormItemInt(getPluginCustomArgName(i * 8 + 0));
-        tmp_config.Rpar[i] = getFormItemInt(getPluginCustomArgName(i * 8 + 1));
+        if (PCONFIG(i + P188_OUTPUT_MAPPING_OFFSET) > 11)


Another one

tonhuisman · 2026-08-23T14:42:02Z

@@ -312,10 +326,10 @@ boolean Plugin_188(uint8_t function, struct EventStruct *event, String& string)
              {
                if ((P188_configBits.en_cal >> i) & 0x01) 


Yes this works, but using bitRead() and a properly named bit-index will have more meaning in 6 months...

tonhuisman · 2026-08-23T14:43:11Z

@@ -381,10 +395,10 @@ boolean Plugin_188(uint8_t function, struct EventStruct *event, String& string)

              if ((P188_configBits.en_cal >> i) & 0x01) 


tonhuisman · 2026-08-23T14:46:05Z

+                  const float out1 = P188_data->P188_config.CalOut[i][0];
+                  const float out2 = P188_data->P188_config.CalOut[i][1];

                  if (adc1 != adc2) 


Now that adc1 and adc2 are float, using !essentiallyEqual() takes care of the inaccuracy of the float type.

tonhuisman · 2026-08-23T14:46:18Z

+                const float out1 = P188_data->P188_config.CalOut[i][0];
+                const float out2 = P188_data->P188_config.CalOut[i][1];

                if (adc1 != adc2) 


tonhuisman · 2026-08-23T17:47:26Z

You haven't included the plugin in the PLUGIN_SET_MAX list in define_plugin_sets.h. By default all plugins should at least be included there. I can't yet see in what 'themed' builds it should go, but maybe it should be included in a Collection build (that would be in the Collection H, as the other builds are quite filled already) and for ESP32 only, like the other plugins in there. If you add it there, it should also be reflected in the documentation. The MAX build is never listed there, btw. You have currently listed it for the Normal build, but that's not where it should go (and it isn't in that set either, as you haven't mentioned it in define_plugin_sets.h yet). What goes in Normal is fixed, and decided by TD-er.

SuksAE and others added 10 commits June 30, 2026 09:37

TLA2528 initial commit

e5f9243

Merge branch 'letscontrolit:mega' into TLA2528

72ab163

added clipping for resistor measurement

1b5c473

Merge branch 'letscontrolit:mega' into TLA2528

2355ac7

Merge branch 'letscontrolit:mega' into TLA2528

0607ace

started documentation

2fb461d

Merge branch 'letscontrolit:mega' into TLA2528

704c4d8

updated documentation

876c7e8

cleanup code & documentation

3eb3e0f

Merge branch 'letscontrolit:mega' into TLA2528

5e343c2

tonhuisman mentioned this pull request Aug 22, 2026

[Plugins] List of planned new plugins (request a Plugin-ID here) #3839

Open

tonhuisman reviewed Aug 22, 2026

View reviewed changes

code and documentation rework

7d77e0b

tonhuisman reviewed Aug 23, 2026

View reviewed changes

		if ((P188_OUTPUT_MAPPING_0 > 11) \|\| (P188_OUTPUT_MAPPING_1 > 11) \|\| (P188_OUTPUT_MAPPING_2 > 11) \|\| (P188_OUTPUT_MAPPING_3 > 11))
		{

		@@ -312,10 +326,10 @@ boolean Plugin_188(uint8_t function, struct EventStruct *event, String& string)
		{
		if ((P188_configBits.en_cal >> i) & 0x01)

		@@ -381,10 +395,10 @@ boolean Plugin_188(uint8_t function, struct EventStruct *event, String& string)

		if ((P188_configBits.en_cal >> i) & 0x01)

Uh oh!

Conversation

SuksAE commented Aug 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SuksAE commented Aug 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tonhuisman commented Aug 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants