Release 1.1.0 — lockstep with libleptris 1.1.0 - #19
Merged
Conversation
- build.yml: pin the C library checkout to v1.1.0 - version.rb: 1.1.0; CHANGELOG entry folding the architecture deepening + noblanks work into this release - Element#key? now calls native leptris_element_has_attribute (export gap closed upstream); the two stale "not exported" comments in ffi.rb are gone and leptris_xinclude_get_encoding is bound - Windows unblocked: libleptris 1.1.0 annotates the five SAX definitions (upstream #430 via #465), so all 9 CI jobs are expected green for the first time Verified against a clean v1.1.0 build: symbol-level compat clean (all 167 attached functions still export), 188/188 specs.
2 tasks
The four wrapper-identity specs failed on the Windows CI matrix (188 examples, 4 failures; mac/linux green): ObjectSpace::WeakMap holds values weakly, so between two doc.root calls the first wrapper was referenced only by the map — any GC sweep evicted it and the second call built a fresh object. Identity was a GC timing race, not a property of the interface. The cache is now a plain Hash owned by the Document and cleared in free. Cost: at most one wrapper per node actually visited, held until the document dies. Full suite 188/188 locally; doc.root.equal?(doc.root) survives 50 forced GC.start rounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lockstep release with libleptris 1.1.0, per the version-lockstep rule (version.rb + build.yml pin + CHANGELOG in one PR):
lib/leptris/version.rb→ 1.1.0.github/workflows/build.yml: C library checkout pinned to v1.1.0CHANGELOG.md: 1.1.0 section folding in the architecture deepening +ParseOptions.noblankswork already on mainElement#key?→ nativeleptris_element_has_attribute(the v0.4.4-era export gap is closed upstream); both stale "not exported" comments removed fromffi.rb;leptris_xinclude_get_encodingnow boundCompat verification (against a clean v1.1.0 build)
-lines were declaration moves, not removals.src/leptris/sax/{parser,streaming}.cnow carry 4+1LEPTRIS_APIannotations (#430 fixed via #465) — all 9 CI jobs expected green, including the three Windows ones that have been red the entire project.New upstream surface not yet bound (follow-up material)
17 new exports: the attribute-iteration face (
element_first_attribute/attribute_next/get_name/get_value), mixed-nodeset API (xpath_result_node_kind/get_node/node_name/node_value),parse/parse_options_init/parse_with_optionsfamily,serialize_document,document_get_dtd,element_prefix,xpath_register_function.Test plan
next_version=skip(version already bumped here)