chore(deps): Bump the k8s.io group to v0.35.8 and sync module versions - #125
Merged
Conversation
Applies the same k8s.io/* bump already made in the root module to hack/tools and test/e2e, so all three modules resolve the same Kubernetes library versions. The bumped set mirrors the root module exactly: api, apiextensions-apiserver, apimachinery, apiserver, client-go and component-base. k8s.io/cluster-bootstrap stays at v0.35.4 to match, and no broad update was run, so no unrelated transitive drift is pulled in. Most of these are indirect requirements in the two side modules, which is unavoidable given neither has a direct dependency on the whole group. google.golang.org/protobuf moves to the pseudo-version that k8s.io v0.35.8 itself requires, matching the root module. Also pins test/e2e to github.com/apache/cloudstack-go/v2 v2.17.1, the same version the manager uses. This is a downgrade from v2.19.0: the CloudStack deployments we test against are old enough that the newer client is not representative, so the e2e suite should exercise the same client version as the controller. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Brings test/e2e up to the versions the root module already uses, ginkgo v2.28.3 and gomega v1.40.0. The Makefile derives GINGKO_VER from the root go.mod, so the runner was already built from v2.28.3 while the e2e module compiled against v2.28.1. github.com/google/pprof moves to a newer pseudo-version as a requirement of ginkgo v2.28.3. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
FarnazBGH
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings
hack/toolsandtest/e2einto line with the root module on three fronts: thek8s.io/*group, the CloudStack API client, and the ginkgo/gomega test libraries.k8s.io group → v0.35.8
Applies the bump already made in the root module to the other two, so all three resolve the same Kubernetes library versions.
The bumped set mirrors the root module exactly —
api,apiextensions-apiserver,apimachinery,apiserver,client-go,component-base— all v0.35.4 → v0.35.8.k8s.io/cluster-bootstrapdeliberately stays at v0.35.4 to match root, and no broadgo get -uwas run, so no unrelated transitive drift is pulled in.Note that most of these are indirect requirements in the two side modules; that is unavoidable, since neither has a direct dependency on the whole group (
hack/toolshas no direct k8s dependency at all). Leaving them out would produce version skew inside a module —api/apimachineryat .8 againstclient-goat .4, since cluster-api v1.13.5 pins .4 — whichgo mod tidywill not reconcile.google.golang.org/protobufmoves to the pseudo-version that k8s.io v0.35.8 itself requires, matching what the root module already carries.cloudstack-go sync (downgrade, intentional)
Pins
test/e2etogithub.com/apache/cloudstack-go/v2v2.17.1, the version the manager uses. This is a downgrade from v2.19.0, and deliberate: the CloudStack deployments we test against are old enough that the newer client is not representative, so the e2e suite should exercise the same client version as the controller. Please don't "fix" this back up in a later dependency sweep.ginkgo / gomega sync
Brings
test/e2eto ginkgo v2.28.3 and gomega v1.40.0, the versions root already uses. The Makefile derivesGINGKO_VERfrom the rootgo.mod(Makefile:96), so the ginkgo runner was already built from v2.28.3 while the e2e module compiled against v2.28.1.github.com/google/pprofmoves to a newer pseudo-version as a requirement of ginkgo v2.28.3.Security note
This PR does not change the Dependabot picture. All 19 open alerts are transitive, across
golang.org/x/crypto,go.opentelemetry.io/otel,otel/sdk,google.golang.org/grpcandgolang.org/x/net, and every one is already remediated ondevelopby the CAPI v1.13.5 upgrade (#123). They are reported against the default branchmain, so they will not close untildevelopreachesmain.Test plan
go build ./... && go vet ./...clean on the root modulego vet -tags e2e ./...clean ontest/e2e— confirms neither the cloudstack-go downgrade nor the ginkgo/gomega bump touches API surface the suite useshack/toolsmdbook binaries buildmake test— Webhook Suite 28/28, Cloud Suite 127/127, allinternal/controllersintegration tests passmake run-e2eneeds a live CloudStack environment — not run here🤖 Generated with Claude Code