Skip to content

[Remove Vuetify from Studio] 'Activation failed' page#6026

Open
LightCreator1007 wants to merge 3 commits into
learningequality:unstablefrom
LightCreator1007:refactor/remove-vuetify-req-activation-page
Open

[Remove Vuetify from Studio] 'Activation failed' page#6026
LightCreator1007 wants to merge 3 commits into
learningequality:unstablefrom
LightCreator1007:refactor/remove-vuetify-req-activation-page

Conversation

@LightCreator1007

Copy link
Copy Markdown
Contributor

Summary

  1. Replaced MessageLayout with StudioMessageLayout
  2. Replaced VForm with and use generateFormMixin for validation
  3. Replaced Banner with StudioBanner
  4. Replaced EmailField with StudioEmailField

References

Fixes #5929

Reviewer guidance

Screencast.From.2026-07-03.01-46-29.mp4
  • there were minor UI changes from the original.
  • The tests still use the unit test suite, should i port it to VTL in this PR or a separate one?

AI usage

Code was reviewed and some adjustments were made with the help of claude. I tried to bring the UI as close as possible to the original layout, and the LLM generated solutions which felt too over the top for the given scope, and the changes in UI were subtle enough to not be too major, so I decided it would be better to leave it alone and look for further clarification on the matter. Changes were overviewed in the best of my abilities.

@learning-equality-bot

Copy link
Copy Markdown

👋 Hi @LightCreator1007, thanks for contributing!

For the review process to begin, please verify that the following is satisfied:

  • Contribution is aligned with our contributing guidelines

  • Pull request description has correctly filled AI usage section & follows our AI guidance:

    AI guidance

    State explicitly whether you didn't use or used AI & how.

    If you used it, ensure that the PR is aligned with Using AI as well as our DEEP framework. DEEP asks you:

    • Disclose — Be open about when you've used AI for support.
    • Engage critically — Question what is generated. Review code for correctness and unnecessary complexity.
    • Edit — Review and refine AI output. Remove unnecessary code and verify it still works after your edits.
    • Process sharing — Explain how you used the AI so others can learn.

    Examples of good disclosures:

    "I used Claude Code to implement the component, prompting it to follow the pattern in ComponentX. I reviewed the generated code, removed unnecessary error handling, and verified the tests pass."

    "I brainstormed the approach with Gemini, then had it write failing tests for the feature. After reviewing the tests, I used Claude Code to generate the implementation. I refactored the output to reduce verbosity and ran the full test suite."

Also check that issue requirements are satisfied & you ran pre-commit locally.

Pull requests that don't follow the guidelines will be closed.

Reviewer assignment can take up to 2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Remove Vuetify from Studio] 'Activation failed' page

1 participant