feat: prove Array.qsort correct - #14658
Open
kim-em wants to merge 1 commit into
Open
Conversation
kim-em
force-pushed
the
agent/array-qsort-proofs
branch
from
August 2, 2026 09:28
8325291 to
c88898b
Compare
kim-em
marked this pull request as ready for review
August 2, 2026 09:42
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds library theorems establishing that
Array.qsortpreserves its input and returns an ordered result.The proofs are designed for the three-way implementation introduced in #14653. They establish preservation of size, permutation and membership, preservation of elements outside the requested interval, orderedness of arbitrary sorted slices, orderedness of complete results, and adjacent-element variants. The theorems live in
Init.Data.Array.QSort.Lemmasand are publicly re-exported byInit.Data.Array.QSort.This replaces the implementation-coupled,
grind-based test-suite verification from #7995. It incorporates the goals of the later completion attempt #12510 and follows the earlier replacement-sort proof work in #5346. The Zulip verification discussion provides additional context for moving these results into the library alongside the new implementation.🤖 prepared with assistance from codex and claude