fix: reduce binder types in reduceAll - #14656
Open
sankalpsthakur wants to merge 1 commit into
Open
Conversation
sankalpsthakur
marked this pull request as ready for review
August 2, 2026 06:58
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
sankalpsthakur
force-pushed
the
agent/reduce-binder-types
branch
from
August 4, 2026 01:46
5f5558c to
d321367
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
reducevisit lambda and forall binder types when type reduction is enabled.The previous lambda/forall cases opened the original binders and reduced only the body. Consequently,
reduceAllcould return an expression such asFoo → Trueeven whenFooreduces toTrue.Reuse the existing binder traversal helpers, which visit each domain and the body in the correct local context. The existing
skipTypesguard preserves the default behavior ofreduce.Closes #6084
Validation
tests/elab/issue6084.leanAI assistance
AI tools assisted with issue triage, source inspection, implementation, and regression preparation. I reviewed the binder traversal helpers and final five-line production diff.