fix: reject a zero thread count - #14652
Open
sankalpsthakur wants to merge 1 commit into
Open
Conversation
sankalpsthakur
marked this pull request as ready for review
August 2, 2026 06:37
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
sankalpsthakur
force-pushed
the
agent/reject-zero-threads
branch
from
August 4, 2026 01:47
a8708bf to
ab93b8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rejects
-j0/--threads=0during shell option processing instead of allowing an invalid task-manager size to reach the runtime.The runtime requires a positive worker count in multithreaded builds. Add an explicit zero check alongside the existing numeric and upper-bound validation, with a focused
tests/miscregression asserting a clean diagnostic and nonzero exit.Closes #4927
Validation
tests/misc/threads_zero.shAI assistance
AI tools assisted with issue triage, duplicate-PR search, implementation, and regression preparation. I reviewed the shell option path and final two-file diff.