-
Notifications
You must be signed in to change notification settings - Fork 38
feat: Add Unconditional Odlyzko Bound problem #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bixbyr
wants to merge
1
commit into
leanprover:main
Choose a base branch
from
bixbyr:add-odlyzko-bound
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import Mathlib | ||
| import EvalTools.Markers | ||
|
|
||
| namespace LeanEval | ||
| namespace NumberTheory | ||
|
|
||
| open NumberField | ||
|
|
||
| /-- **Unconditional Odlyzko Bound**. | ||
| There exists a constant `c > 0` such that for every number field `K`, | ||
| the absolute value of its discriminant is bounded below by `(60.8)^{r_1} * (22.3)^{2 r_2} * e^{-c}`, | ||
| where `r_1` and `r_2` are the number of real and complex places of `K` respectively. -/ | ||
| @[eval_problem] | ||
| theorem odlyzko_bound_unconditional : | ||
| ∃ (c : ℝ), 0 < c ∧ | ||
| ∀ (K : Type*) [Field K] [NumberField K], | ||
| let r1 := (InfinitePlace.nrRealPlaces K : ℝ) | ||
| let r2 := (InfinitePlace.nrComplexPlaces K : ℝ) | ||
| ((discr K).natAbs : ℝ) ≥ (60.8 : ℝ) ^ r1 * (22.3 : ℝ) ^ (2 * r2) * Real.exp (-c) := by | ||
| sorry | ||
|
|
||
| end NumberTheory | ||
| end LeanEval | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| id = "odlyzko_bound" | ||
| title = "Unconditional Odlyzko Bound" | ||
| test = false | ||
| module = "LeanEval.NumberTheory.OdlyzkoBound" | ||
| holes = ["odlyzko_bound_unconditional"] | ||
| submitter = "Ryan Smith" | ||
| notes = "The finite, unconditional version of the Odlyzko bound for the absolute discriminant of a number field, framed as an existence theorem for the constants." | ||
| source = "Odlyzko, A. M. (1976). 'Lower bounds for discriminants of number fields.' Acta Arithmetica, 29(3), 275-297. See also Odlyzko, A. M. (1990) 'Bounds for discriminants and related estimates...'" | ||
| informal_solution = "The proof evaluates the explicit formulas connecting the Dedekind zeta function to prime ideals using a specially chosen non-negative test function. By discarding the positive sum over the non-trivial zeros (unconditionally), one isolates log|D_K| on one side and a sum of integrals on the other, yielding the required constants." |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is equivalent to
and I think it's better to use Real.eulerMascheroniConstant and

Real.piin the bases of the exponentiation.(formula from ImperialCollegeLondon/FLT#458 (comment))