Skip to content

fix: /check-golf --measure crash (def_body_changed -> def_value_changed)#1399

Merged
jstoobysmith merged 1 commit into
leanprover-community:masterfrom
Vilin97:fix-check-golf-measure
Jul 9, 2026
Merged

fix: /check-golf --measure crash (def_body_changed -> def_value_changed)#1399
jstoobysmith merged 1 commit into
leanprover-community:masterfrom
Vilin97:fix-check-golf-measure

Conversation

@Vilin97

@Vilin97 Vilin97 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

The measure-path file selection in scripts/check_golf.py (added in #1356) references a nonexistent FileReport attribute def_body_changed; the field is named def_value_changed. As a result every /check-golf run since #1356 crashes with an AttributeError after building the head, so the report comment is never posted/updated (see e.g. this run on #1364).

One-line fix.

🤖 Generated with Claude Code

The measure-path file selection in scripts/check_golf.py references a
nonexistent FileReport attribute (def_body_changed); the field is named
def_value_changed. Every /check-golf --measure run since leanprover-community#1356 crashes
with an AttributeError after building the head, so the report comment
is never updated.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for this PR, which will now be reviewed. If submitting to ./Physlib or ./QuantumInfo, please see our review guidelines if you are not familiar with the process. You should expect a back and forth with a reviewer before your PR is merged. See also that link for how to add appropriate labels to your PR. The PR will also go through a number of automated checks. You can learn more about these here, including how to run them locally.

If you are submitting to ./PhyslibAlpha there will be a lighter review process, though your PR must still pass the automated checks.

If you want to bring attention to this PR, please write a message on this thread of the Lean Zulip.

Important: If a reviewer adds an awaiting-author label to your PR, once you have addressed the review comments, please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - will merge now

@jstoobysmith jstoobysmith added the ready-to-merge This PR is approved and will be merged shortly label Jul 9, 2026
@jstoobysmith jstoobysmith self-assigned this Jul 9, 2026
@jstoobysmith jstoobysmith merged commit a3ef9c7 into leanprover-community:master Jul 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR is approved and will be merged shortly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants