fix: /check-golf --measure crash (def_body_changed -> def_value_changed)#1399
Conversation
The measure-path file selection in scripts/check_golf.py references a nonexistent FileReport attribute (def_body_changed); the field is named def_value_changed. Every /check-golf --measure run since leanprover-community#1356 crashes with an AttributeError after building the head, so the report comment is never updated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Thank you for this PR, which will now be reviewed. If submitting to ./Physlib or ./QuantumInfo, please see our review guidelines if you are not familiar with the process. You should expect a back and forth with a reviewer before your PR is merged. See also that link for how to add appropriate labels to your PR. The PR will also go through a number of automated checks. You can learn more about these here, including how to run them locally. If you are submitting to ./PhyslibAlpha there will be a lighter review process, though your PR must still pass the automated checks. If you want to bring attention to this PR, please write a message on this thread of the Lean Zulip. Important: If a reviewer adds an |
jstoobysmith
left a comment
There was a problem hiding this comment.
Approved - will merge now
The measure-path file selection in
scripts/check_golf.py(added in #1356) references a nonexistentFileReportattributedef_body_changed; the field is nameddef_value_changed. As a result every/check-golfrun since #1356 crashes with anAttributeErrorafter building the head, so the report comment is never posted/updated (see e.g. this run on #1364).One-line fix.
🤖 Generated with Claude Code