refactor: Rename dropPairEmb to Fin.succSuccAbove#1099
Merged
jstoobysmith merged 10 commits intoMay 23, 2026
Conversation
Member
Author
|
RFC |
Collaborator
morrison-daniel
left a comment
morrison-daniel
left a comment
There was a problem hiding this comment.
I would also add a TODO to come back to the definition of sucSuccAbove because I think we can simplify it greatly by rewriting in terms of more basic function on Fin which would clean up a lot.
Member
Author
|
@morrison-daniel Fixed these comments, I added the TODO item. I've actually tried to make the replacement of |
Collaborator
|
Looks like something broke when golfing |
morrison-daniel
added
the
awaiting-author
Member
Author
|
@morrison-daniel Should have fixed the build now. Sorry about this. -awaiting-author |
github-actions
Bot
removed
the
awaiting-author
morrison-daniel
approved these changes
May 22, 2026
morrison-daniel
added
the
ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
dropPairEmbto the more descriptive nameFin.succSuccAbove, and seperate results surrounding this into there own file.