Skip to content

feat(NumberTheory/EllipticDivisibilitySequence): add some lemmas and grind some proofs - #42477

Open
Multramate wants to merge 5 commits into
leanprover-community:masterfrom
Multramate:IsEllipticSequence
Open

feat(NumberTheory/EllipticDivisibilitySequence): add some lemmas and grind some proofs#42477
Multramate wants to merge 5 commits into
leanprover-community:masterfrom
Multramate:IsEllipticSequence

Conversation

@Multramate

@Multramate Multramate commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Also rename odd to neg because odd will be reserved for odd elliptic relations.


Open in Gitpod

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

PR summary b89e87277a

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.NumberTheory.EllipticDivisibilitySequence 751 730 -21 (-2.80%)
Import changes for all files
Files Import difference
Mathlib.NumberTheory.EllipticDivisibilitySequence -21

Declarations diff (regex)

+ atomRel_abs
+ atomRel_even
+ atomRel_neg
+ atomRel_odd
+ neg_atomRel₁₂
+ neg_atomRel₂₃
+ neg_atomRel₃₄
+ normEDS_atomRel_even
+ normEDS_atomRel_odd
++++ comp

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit b89e872).

  • +13 new declarations
  • −0 removed declarations
+IsDvdSequence.comp
+IsEllipticDvdSequence.comp
+IsEllipticNet.atomRel_abs
+IsEllipticNet.atomRel_even
+IsEllipticNet.atomRel_neg
+IsEllipticNet.atomRel_odd
+IsEllipticNet.comp
+IsEllipticNet.neg_atomRel₁₂
+IsEllipticNet.neg_atomRel₂₃
+IsEllipticNet.neg_atomRel₃₄
+IsEllipticSequence.comp
+normEDS_atomRel_even
+normEDS_atomRel_odd

No changes to strong technical debt.

No changes to weak technical debt.

Current commit b89e87277a
Reference commit 20a3b032e0

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Multramate
Multramate requested a review from tb65536 August 5, 2026 12:55
@Multramate Multramate added t-number-theory Number theory (also use t-algebra or t-analysis to specialize) t-algebra Algebra (groups, rings, fields, etc) labels Aug 5, 2026
@Multramate
Multramate requested a review from alreadydone August 5, 2026 13:02
Comment thread Mathlib/NumberTheory/EllipticDivisibilitySequence.lean

@tb65536 tb65536 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by tb65536.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-algebra Algebra (groups, rings, fields, etc) t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants