Skip to content

chore(Data/List/Lookmap): remove import all - #42454

Open
thorimur wants to merge 2 commits into
leanprover-community:masterfrom
thorimur:lookmap-cleanup
Open

chore(Data/List/Lookmap): remove import all#42454
thorimur wants to merge 2 commits into
leanprover-community:masterfrom
thorimur:lookmap-cleanup

Conversation

@thorimur

@thorimur thorimur commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

This PR removes an unnecessary import all and further minimizes imports in Mathlib.Data.List.Lookmap. Found while exploring uses of import all in mathlib.


Open in Gitpod

@thorimur thorimur changed the title chore: remove import all from Mathlib.Data.List.Lookmap chore(Data.List.Lookmap): remove import all Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

PR summary 9cfb293306

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Data.List.Lookmap 62 60 -2 (-3.23%)
Import changes for all files
Files Import difference
Mathlib.Data.List.Lookmap -2
6 files Mathlib.Data.Finmap Mathlib.Data.Finsupp.AList Mathlib.Data.List.AList Mathlib.Data.List.Sigma Mathlib.SetTheory.Ordinal.CantorNormalForm Mathlib.Testing.Plausible.Functions
-1

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 9cfb293).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 9cfb293306
Reference commit 4d6f98930f

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@thorimur thorimur added the easy < 20s of review time. See the lifecycle page for guidelines. label Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@github-actions github-actions Bot added the t-data Data (lists, quotients, numbers, etc) label Aug 4, 2026
@thorimur thorimur changed the title chore(Data.List.Lookmap): remove import all chore(Data/List/Lookmap): remove import all Aug 4, 2026

@grunweg grunweg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer delegate

Comment thread Mathlib/Data/List/Lookmap.lean Outdated
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by grunweg.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants