Skip to content

Fix legacy moves overwriting pending window sizes - #611

Closed
lijy91 wants to merge 2 commits into
mainfrom
fix/issue-37-preserve-pending-size
Closed

lijy91 wants to merge 2 commits into
mainfrom
fix/issue-37-preserve-pending-size

Conversation

@lijy91

@lijy91 lijy91 commented Nov 21, 2026

Copy link
Copy Markdown
Member

Fixes libnativeapi/nativeapi#37

Position-only and size-only legacy geometry updates now write only the requested component. This preserves a resize or move that an asynchronous window manager has not applied yet, including when native frame animation is unavailable. Full bounds updates and supported native animation retain their existing behavior.

Added regression tests with a window that reports stale geometry: three cases fail before the fix and pass after it.

Validation: flutter --no-version-check test --no-pub (9 tests passed), flutter --no-version-check analyze --no-pub lib test (no issues), and git diff --check. Native Linux GUI behavior has not been exercised in this PR.

@lijy91

lijy91 commented Nov 22, 2026

Copy link
Copy Markdown
Member Author

Superseded by #610 (merged in bac0cfb), which fixes the same pending-size overwrite bug in setPosition/setBounds and waitUntilReadyToShow. Closing.

@lijy91 lijy91 closed this Nov 22, 2026
@lijy91
lijy91 deleted the fix/issue-37-preserve-pending-size branch November 22, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux: setPosition and setAlignment cancel a setSize call that comes before them

1 participant