Refactor/cubit to notifier migration#42
Open
aydinguven-leancode wants to merge 23 commits into
Open
Conversation
…nagement Migrated from Cubit (Bloc) to value notifier. Removed dependencies: flutter_bloc, rx_dart, equatable, Changes are reflected on examples Changes are reflected on tests
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Albert221
reviewed
Jun 19, 2026
| FieldBuilder<String, ValidationError>( | ||
| field: context.read<SignupController>().email, | ||
| builder: (context, state) => TextFormField( | ||
| controller: context.read<SignupController>().email.textController, |
Member
There was a problem hiding this comment.
We already passed the field controller, why fetch it again? Please just add the field controller itself into the builder callback params.
Author
There was a problem hiding this comment.
Hi, while the examples changed drastically, the point having the fieldController as a part of builder params makes sense. I have prepared a PoC on how this could work, here is the PR about that: #43
the PR is breaking things and having a conflict but if you could share your opinion on the core idea of using instead of <T, E> that would be already great.
cupofme
reviewed
Jun 19, 2026
cupofme
reviewed
Jun 19, 2026
Removed unnecessary //ignore commands Reverted version change on leancode_lint in example project Added debugLabel
….com/leancodepl/leancode_forms into refactor/cubit-to-notifier-migration
Examples modified FormGroupState is renamed into FormState
Examples and tests modified accordingly
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Added isDisposed flag to the FormController class + tests
…ld-subscription-fix Added an example with autoValidation + subscribeToFields combo
* Added FocusNode support in AdvancedTextFieldController * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
aydinguven-leancode
requested review from
Albert221,
KamilSztandur,
PiotrRogulski and
cupofme
Comment on lines
+37
to
+40
| /// Optional name for the field. Useful for debugging, logging, and | ||
| /// serialization. Not used for identity — fields are still identified by | ||
| /// reference. | ||
| final String? name; |
Member
There was a problem hiding this comment.
I think that maybe an example with these names would be useful; I'm still not sure how to use this field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LMG-394
flutter_bloc,rx_dart, flutter_hooks,equatable`LMG-404
Migration.mdfile