-
Notifications
You must be signed in to change notification settings - Fork 215
fix(UserSearchField): restore type-ahead broken by MUI v9 slotProps migration #1608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import { fireEvent, render, screen, waitFor } from '@testing-library/react'; | ||
| import React from 'react'; | ||
| import UserSearchField from '../custom/UserSearchField/UserSearchFieldInput'; | ||
| import { SistentThemeProvider } from '../theme'; | ||
|
|
||
| // Regression guard for the user-picker type-ahead. | ||
| // | ||
| // The picker is a controlled MUI Autocomplete. In MUI v9 the `renderInput` | ||
| // params expose the native <input> wiring (value, onChange, onKeyDown, focus | ||
| // handlers and the anchor ref from `getInputProps`) under | ||
| // `params.slotProps.htmlInput`. If the TextField is handed an explicit | ||
| // `slotProps` object that omits `htmlInput`, that object REPLACES the one | ||
| // spread from `{...params}` and the input is silently disconnected from the | ||
| // Autocomplete: keystrokes no longer reach `onInputChange`, the search never | ||
| // fires and the suggestion list never opens. These tests assert the wiring | ||
| // survives so the type-ahead keeps working. | ||
|
|
||
| type FieldProps = React.ComponentProps<typeof UserSearchField>; | ||
|
|
||
| const renderWithTheme = (ui: React.ReactElement) => | ||
| render(<SistentThemeProvider>{ui}</SistentThemeProvider>); | ||
|
|
||
| const jane = { | ||
| userId: 'u-jane', | ||
| firstName: 'Jane', | ||
| lastName: 'Doe', | ||
| email: 'jane@example.com' | ||
| }; | ||
|
|
||
| const renderField = (overrides: Partial<FieldProps> = {}) => { | ||
| const props: FieldProps = { | ||
| usersData: [], | ||
| setUsersData: jest.fn(), | ||
| currentUserData: null, | ||
| searchedUsers: [jane], | ||
| isUserSearchLoading: false, | ||
| fetchSearchedUsers: jest.fn(), | ||
| usersSearch: '', | ||
| setUsersSearch: jest.fn(), | ||
| ...overrides | ||
| }; | ||
| const utils = renderWithTheme(<UserSearchField {...props} />); | ||
| const input = screen.getByRole('combobox') as HTMLInputElement; | ||
| return { props, input, ...utils }; | ||
| }; | ||
|
|
||
| describe('UserSearchField type-ahead wiring', () => { | ||
| it('forwards keystrokes to the search callback', () => { | ||
| const { props, input } = renderField(); | ||
|
|
||
| fireEvent.change(input, { target: { value: 'jane' } }); | ||
|
|
||
| // Only reachable when the Autocomplete's htmlInput slot is forwarded to | ||
| // the TextField; a dropped slot leaves the input inert and this stays 0. | ||
| expect(props.fetchSearchedUsers).toHaveBeenCalledWith('jane'); | ||
| }); | ||
|
|
||
| it('opens the suggestion list with matching users as the query is typed', async () => { | ||
| const { input } = renderField({ usersSearch: 'jane' }); | ||
|
|
||
| fireEvent.change(input, { target: { value: 'jane' } }); | ||
|
|
||
| await waitFor(() => { | ||
| expect(screen.queryByText('jane@example.com')).not.toBeNull(); | ||
| }); | ||
| expect(screen.queryByText('Jane Doe')).not.toBeNull(); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.