Standardize Icon Dimensions Using DEFAULT_WIDTH and DEFAULT_HEIGHT#1592
Standardize Icon Dimensions Using DEFAULT_WIDTH and DEFAULT_HEIGHT#1592Rajesh-Nagarajan-11 wants to merge 4 commits into
Conversation
Signed-off-by: Rajesh-Nagarajan-11 <rajeshnagarajan36@gmail.com>
Signed-off-by: Rajesh-Nagarajan-11 <rajeshnagarajan36@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request standardizes the default dimensions of various icon components by importing and applying DEFAULT_WIDTH and DEFAULT_HEIGHT constants to their width and height props. Additionally, some prop types were updated to be optional and accept both numbers and strings. The review feedback suggests formatting improvements across several icon files to ensure that each destructured prop is placed on its own line when split across multiple lines, enhancing code readability and consistency.
Signed-off-by: Rajesh-Nagarajan-11 <rajeshnagarajan36@gmail.com>
|
@Rajesh-Nagarajan-11 Replacing unique default dimensions with global defaults (
Should we keep custom default constants for these specific sub-families of icons, or are we expecting consuming products to explicitly pass overrides at every usage site? |
Notes for Reviewers
Ensured every icon consistently defaults to DEFAULT_WIDTH and DEFAULT_HEIGHT.
Many icons were either missing fallback values entirely or using hardcoded dimensions (such as '24px' or '32px'). This update standardizes them all for consistency and follows the same implementation pattern used across other icons.
Signed commits