Testing: resolve 404 page asset loading on nested routes#1073
Testing: resolve 404 page asset loading on nested routes#1073Bhumikagarggg wants to merge 10 commits into
Conversation
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request updates asset paths across various layout templates and partials to use absolute URLs, and removes the scripts partial from the 404 page. The review feedback points out a security regression in head-css.html due to the removal of Subresource Integrity (SRI) attributes, suggesting the use of .Permalink instead. Additionally, several comments recommend standardizing HTML formatting by using double quotes for attributes, removing leading slashes in asset paths, and cleaning up extra spaces within Hugo template tags.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| <link rel="icon" type="image/png" sizes="32x32" href='{{ "favicons/favicon-32x32.png" | absURL }}'> | ||
| <link rel="icon" type="image/png" sizes="16x16" href='{{ "favicons/favicon-16x16.png" | absURL }}'> | ||
| <link rel="manifest" href='{{ "/favicons/site.webmanifest" | absURL}}'> |
There was a problem hiding this comment.
Use double quotes for HTML attributes to maintain consistency with the rest of the codebase and standard HTML formatting. Additionally, ensure consistent path formatting (e.g., removing the leading slash and extra spaces before the pipe operator).
| <link rel="icon" type="image/png" sizes="32x32" href='{{ "favicons/favicon-32x32.png" | absURL }}'> | |
| <link rel="icon" type="image/png" sizes="16x16" href='{{ "favicons/favicon-16x16.png" | absURL }}'> | |
| <link rel="manifest" href='{{ "/favicons/site.webmanifest" | absURL}}'> | |
| <link rel="icon" type="image/png" sizes="32x32" href="{{ "favicons/favicon-32x32.png" | absURL }}"> | |
| <link rel="icon" type="image/png" sizes="16x16" href="{{ "favicons/favicon-16x16.png" | absURL }}"> | |
| <link rel="manifest" href="{{ "favicons/site.webmanifest" | absURL }}"> |
| <link rel="manifest" href='{{ "/favicons/site.webmanifest" | absURL}}'> | ||
| <link rel="mask-icon" href="/favicons/safari-pinned-tab.svg"> | ||
| <link rel="shortcut icon" href="/favicons/favicon.ico"> | ||
| <link rel="shortcut icon" href='{{ "favicons/favicon.ico" | absURL }}'> |
There was a problem hiding this comment.
| <span class="navbar-brand__logo navbar-logo"> | ||
| {{ $svg := resources.Get "icons/logo.svg" }} | ||
| <img class="footer-logo" src="/images/logo.svg" alt="logo" data-modal="false" /> | ||
| <img class="footer-logo" src='{{ "images/logo.svg" | absURL }}' alt="logo" data-modal="false" /> |
There was a problem hiding this comment.
| <div class="logo-container"> | ||
| <img | ||
| src="/images/academy-icon.svg" | ||
| src='{{ "/images/academy-icon.svg" | absURL }}' |
| <div class="logo-container"> | ||
| <img | ||
| src="/images/logos/kanvas-icon-color.svg" | ||
| src='{{ "/images/logos/kanvas-icon-color.svg" | absURL }}' |
| <div class="logo-container"> | ||
| <img | ||
| src="/images/logos/catalog.svg" | ||
| src='{{ "/images/logos/catalog.svg" | absURL }}' |
| <div class="logo-container"> | ||
| <img | ||
| src="/images/logos/smp-light.png" | ||
| src='{{ "/images/logos/smp-light.png" | absURL }}' |
| <div class="logo-container"> | ||
| <img | ||
| src="/images/logos/nighthawk-logo.svg" | ||
| src='{{ "/images/logos/nighthawk-logo.svg" | absURL }}' |
| <div class="logo-container"> | ||
| <img | ||
| src="/images/logos/academy.svg" | ||
| src='{{ "/images/logos/academy.svg" | absURL }}' |
|
🚀 Preview deployment: https://layer5io.github.io/docs/pr-preview/pr-1073/
|
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Notes for Reviewers
This PR fixes #
Signed commits