Skip to content

Testing: resolve 404 page asset loading on nested routes#1073

Draft
Bhumikagarggg wants to merge 10 commits into
layer5io:masterfrom
Bhumikagarggg:fix/404-nested-route-assets
Draft

Testing: resolve 404 page asset loading on nested routes#1073
Bhumikagarggg wants to merge 10 commits into
layer5io:masterfrom
Bhumikagarggg:fix/404-nested-route-assets

Conversation

@Bhumikagarggg
Copy link
Copy Markdown
Contributor

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates asset paths across various layout templates and partials to use absolute URLs, and removes the scripts partial from the 404 page. The review feedback points out a security regression in head-css.html due to the removal of Subresource Integrity (SRI) attributes, suggesting the use of .Permalink instead. Additionally, several comments recommend standardizing HTML formatting by using double quotes for attributes, removing leading slashes in asset paths, and cleaning up extra spaces within Hugo template tags.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread layouts/partials/head-css.html Outdated
Comment on lines +2 to +4
<link rel="icon" type="image/png" sizes="32x32" href='{{ "favicons/favicon-32x32.png" | absURL }}'>
<link rel="icon" type="image/png" sizes="16x16" href='{{ "favicons/favicon-16x16.png" | absURL }}'>
<link rel="manifest" href='{{ "/favicons/site.webmanifest" | absURL}}'>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use double quotes for HTML attributes to maintain consistency with the rest of the codebase and standard HTML formatting. Additionally, ensure consistent path formatting (e.g., removing the leading slash and extra spaces before the pipe operator).

Suggested change
<link rel="icon" type="image/png" sizes="32x32" href='{{ "favicons/favicon-32x32.png" | absURL }}'>
<link rel="icon" type="image/png" sizes="16x16" href='{{ "favicons/favicon-16x16.png" | absURL }}'>
<link rel="manifest" href='{{ "/favicons/site.webmanifest" | absURL}}'>
<link rel="icon" type="image/png" sizes="32x32" href="{{ "favicons/favicon-32x32.png" | absURL }}">
<link rel="icon" type="image/png" sizes="16x16" href="{{ "favicons/favicon-16x16.png" | absURL }}">
<link rel="manifest" href="{{ "favicons/site.webmanifest" | absURL }}">

<link rel="manifest" href='{{ "/favicons/site.webmanifest" | absURL}}'>
<link rel="mask-icon" href="/favicons/safari-pinned-tab.svg">
<link rel="shortcut icon" href="/favicons/favicon.ico">
<link rel="shortcut icon" href='{{ "favicons/favicon.ico" | absURL }}'>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use double quotes for the href attribute to match standard HTML formatting and maintain consistency.

Suggested change
<link rel="shortcut icon" href='{{ "favicons/favicon.ico" | absURL }}'>
<link rel="shortcut icon" href="{{ "favicons/favicon.ico" | absURL }}">

Comment thread layouts/partials/navbar.html Outdated
<span class="navbar-brand__logo navbar-logo">
{{ $svg := resources.Get "icons/logo.svg" }}
<img class="footer-logo" src="/images/logo.svg" alt="logo" data-modal="false" />
<img class="footer-logo" src='{{ "images/logo.svg" | absURL }}' alt="logo" data-modal="false" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use double quotes for the src attribute to maintain HTML attribute consistency.

Suggested change
<img class="footer-logo" src='{{ "images/logo.svg" | absURL }}' alt="logo" data-modal="false" />
<img class="footer-logo" src="{{ "images/logo.svg" | absURL }}" alt="logo" data-modal="false" />

Comment thread layouts/partials/navbar.html Outdated
<div class="logo-container">
<img
src="/images/academy-icon.svg"
src='{{ "/images/academy-icon.svg" | absURL }}'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use double quotes for the src attribute and remove the leading slash for consistency with other asset paths.

Suggested change
src='{{ "/images/academy-icon.svg" | absURL }}'
src="{{ "images/academy-icon.svg" | absURL }}"

Comment thread layouts/partials/navbar.html Outdated
<div class="logo-container">
<img
src="/images/logos/kanvas-icon-color.svg"
src='{{ "/images/logos/kanvas-icon-color.svg" | absURL }}'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use double quotes for the src attribute and remove the leading slash for consistency.

Suggested change
src='{{ "/images/logos/kanvas-icon-color.svg" | absURL }}'
src="{{ "images/logos/kanvas-icon-color.svg" | absURL }}"

Comment thread layouts/partials/navbar.html Outdated
<div class="logo-container">
<img
src="/images/logos/catalog.svg"
src='{{ "/images/logos/catalog.svg" | absURL }}'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use double quotes for the src attribute and remove the leading slash for consistency.

Suggested change
src='{{ "/images/logos/catalog.svg" | absURL }}'
src="{{ "images/logos/catalog.svg" | absURL }}"

Comment thread layouts/partials/navbar.html Outdated
<div class="logo-container">
<img
src="/images/logos/smp-light.png"
src='{{ "/images/logos/smp-light.png" | absURL }}'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use double quotes for the src attribute, remove the leading slash, and clean up the double spaces before the pipe operator for consistency.

Suggested change
src='{{ "/images/logos/smp-light.png" | absURL }}'
src="{{ "images/logos/smp-light.png" | absURL }}"

Comment thread layouts/partials/navbar.html Outdated
<div class="logo-container">
<img
src="/images/logos/nighthawk-logo.svg"
src='{{ "/images/logos/nighthawk-logo.svg" | absURL }}'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use double quotes for the src attribute and remove the leading slash for consistency.

Suggested change
src='{{ "/images/logos/nighthawk-logo.svg" | absURL }}'
src="{{ "images/logos/nighthawk-logo.svg" | absURL }}"

Comment thread layouts/partials/navbar.html Outdated
<div class="logo-container">
<img
src="/images/logos/academy.svg"
src='{{ "/images/logos/academy.svg" | absURL }}'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use double quotes for the src attribute, remove the leading slash, and clean up the double spaces before the pipe operator for consistency.

Suggested change
src='{{ "/images/logos/academy.svg" | absURL }}'
src="{{ "images/logos/academy.svg" | absURL }}"

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 3, 2026

🚀 Preview deployment: https://layer5io.github.io/docs/pr-preview/pr-1073/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
@Bhumikagarggg Bhumikagarggg marked this pull request as draft June 3, 2026 19:47
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
Signed-off-by: Bhumika Garg <bhumikatech2024@gmail.com>
@Bhumikagarggg Bhumikagarggg changed the title fix: resolve 404 page asset loading on nested routes Testing: resolve 404 page asset loading on nested routes Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant