Simplification pass: remove redundant tests and single-use indirection - #24
Merged
Conversation
Delete duplicate explanation-mapping tests fully covered by the classifier-driven drift cases, two signature-only render_diff tests, a duplicate ExtractedPage shape test, a tautological phase test, and an uncollected PNG fixture self-test in conftest.
…cessor Replace three identical propose_plan test factories with one shared canonical_plan_call() helper in the fake-LLM module and migrate its ten callers. Delete the spinner's test-only _current_label_text accessor; tests read _frame(0).plain directly.
…scans Replace the max_plan_steps forwarding property with a plain attribute, inline the single-use audit redaction toggle while keeping per-value redaction, and merge the duplicate active/pending plan-step scans into one _plan_step(active_only=) helper. Characterization tests added for the per-value redaction invariant and the pending-step fallback; DESIGN.md references updated in the same change.
…display Inline the three single-caller command-policy helpers at their call sites, preserving first-match helper detection, option parsing, and all reason strings and risk levels; add characterization tests that pin the exact affected branches. Extract the duplicated live-workspace path-display adapter from both UIs into make_workspace_path_display() in tools.base, with strengthened live-over-stale display tests.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the twelve verified simplifications from the v0.11.3 audit as four scoped commits.
Changes
render_difftests, a duplicateExtractedPageshape test, a tautological phase test, and an uncollected fixture self-test inconftest.py.canonical_plan_call()helper replaces three identical propose-plan factories (ten call sites); drop the spinner's test-only_current_label_textaccessor.max_plan_stepsattribute instead of a forwarding property; inline the single-use audit redaction toggle (per-value redaction preserved and now pinned by a test); merge the duplicate active/pending plan-step scans into_plan_step(active_only=).command_policyhelpers inlined with characterization tests pinning the exact affected branches (first-match helper detection, clustered short-option parsing, format-field normalization); the duplicated live-workspace path-display adapter in both UIs extracted tomake_workspace_path_display()intools.base, with strengthened live-over-stale display tests.Numbers
docs/DESIGN.mdinternal references updated in the same commitsVerification