fix: upgrade @rollup/plugin-terser to fix serialize-javascript vulnerability#398
Merged
Merged
Conversation
…ability Upgrade @rollup/plugin-terser from ^0.4.3 to ^1.0.0 to resolve high-severity vulnerabilities in serialize-javascript (GHSA-5c6j-r48x-rmvq, GHSA-qj8w-gfj5-8c6v). Co-Authored-By: Patrick Kaeding <patrick@kaeding.name>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
joker23
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: upgrade @rollup/plugin-terser to fix serialize-javascript vulnerability
END_COMMIT_OVERRIDE
Requirements
Related issues
Remediates high-severity Dependabot alerts for
serialize-javascript:RegExp.flagsandDate.prototype.toISOString()Describe the solution you've provided
Upgrades
@rollup/plugin-terserfrom^0.4.3to^1.0.0. The new version depends onserialize-javascript@^7.0.3, which resolves to7.0.5(the patched version). The plugin's peer dependency on rollup (^2.0.0||^3.0.0||^4.0.0) is unchanged, so no other changes are needed.Build and all 93 tests pass with the upgrade.
Describe alternatives you've considered
An npm
overridesfield to forceserialize-javascript@7.0.5under the old terser version, but a clean major bump is simpler and better maintained.Additional context
This is a devDependency-only change — no runtime code is affected.
Link to Devin session: https://app.devin.ai/sessions/f782088a3883446e8bb7b049e5631747
Requested by: @pkaeding