Skip to content

chore: Remove dead install_types mypy config#200

Merged
jsonbailey merged 1 commit into
mainfrom
jb/chore-mypy-install-types-cleanup
Jun 5, 2026
Merged

chore: Remove dead install_types mypy config#200
jsonbailey merged 1 commit into
mainfrom
jb/chore-mypy-install-types-cleanup

Conversation

@jsonbailey
Copy link
Copy Markdown
Contributor

@jsonbailey jsonbailey commented Jun 4, 2026

Summary

  • Removes install_types = true and non_interactive = true from the [tool.mypy] section in all three package pyproject.toml files (server-ai, server-ai-openai, server-ai-langchain).
  • These settings were inherited from the Poetry era. Poetry venvs include pip, so mypy's install_types mechanism could auto-install missing type stubs via python -m pip install. After the migration to uv (PR chore: Migrate from Poetry to uv workspace (PR-1) #101), uv-managed venvs do not include pip, making these settings a silent no-op.
  • The AI SDK packages don't import any untyped third-party packages — launchdarkly-server-sdk, chevron, langchain, and openai all ship their own type information — so no explicit stubs need to be added; the settings can simply be removed.

Test plan

  • make lint passes in packages/sdk/server-ai with no mypy errors

Note

Low Risk
Config-only cleanup with no runtime or typing behavior change beyond removing ineffective mypy flags.

Overview
Removes install_types = true and non_interactive = true from [tool.mypy] in packages/sdk/server-ai, packages/ai-providers/server-ai-openai, and packages/ai-providers/server-ai-langchain.

Those flags only auto-installed missing stubs when mypy could run pip in the active venv. After the move to uv, venvs typically lack pip, so the options did nothing. python_version and ignore_missing_imports are unchanged; third-party deps in these packages already ship types, so no stub replacements were added.

Reviewed by Cursor Bugbot for commit 67b04b0. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jsonbailey jsonbailey marked this pull request as ready for review June 5, 2026 15:58
@jsonbailey jsonbailey requested a review from a team as a code owner June 5, 2026 15:58
@jsonbailey jsonbailey merged commit 5d8da38 into main Jun 5, 2026
47 checks passed
@jsonbailey jsonbailey deleted the jb/chore-mypy-install-types-cleanup branch June 5, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants