Skip to content

chore(setup): add setup flag verifier - #752

Open
ffantl-ld wants to merge 1 commit into
ffantl/setup-ld/3-initializerfrom
ffantl/setup-ld/4-verifier
Open

chore(setup): add setup flag verifier#752
ffantl-ld wants to merge 1 commit into
ffantl/setup-ld/3-initializerfrom
ffantl/setup-ld/4-verifier

Conversation

@ffantl-ld

@ffantl-ld ffantl-ld commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Describe the solution you've provided

Fourth layer of the guided setup command: the verifier. Polls the LaunchDarkly API to confirm the newly configured SDK has evaluated a flag, so setup can report success (Verifier, DefaultVerifier). Uses the existing resources.Client.

Related issues

Part of the setup-ld feature. Stacked PR — base is ffantl/setup-ld/3-initializer.

Requirements

  • I have added test coverage for new or changed functionality

Note

Low Risk
New setup-only polling helper using the existing HTTP client; no auth or data-model changes.

Overview
Adds a setup verifier so guided setup can confirm the SDK is live after configuration.

A new Verifier polls GET .../sdk-active via resources.Client until active is true or a configurable timeout (defaults: 5s interval, 120s timeout). It returns a VerifyResult with success, attempt count, and elapsed time. DefaultVerifier wires the standard polling settings.

Unit tests cover immediate success and timeout when the endpoint stays inactive.

Reviewed by Cursor Bugbot for commit 8a8d586. Bugbot is set up for automated code reviews on this repo. Configure here.

@ffantl-ld
ffantl-ld marked this pull request as ready for review July 27, 2026 17:23
@ffantl-ld
ffantl-ld requested review from Vadman97 and erangeles July 27, 2026 17:23

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 00ada35. Configure here.

Comment thread internal/setup/verifier.go
@ffantl-ld
ffantl-ld requested review from a team and removed request for Vadman97 July 28, 2026 16:38
@ffantl-ld
ffantl-ld force-pushed the ffantl/setup-ld/4-verifier branch from 00ada35 to eff8764 Compare July 31, 2026 17:48
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ffantl-ld
ffantl-ld force-pushed the ffantl/setup-ld/4-verifier branch from eff8764 to 8a8d586 Compare July 31, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant