docs(agents): fetch canonical requester-role-lookup from gonfalon#1949
Merged
Conversation
|
nhironaka
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the inline copy of the non-engineer scope warning's role-lookup section (engineer team allowlist + bash) with a runtime fetch of the canonical
requester-role-lookupskill from gonfalon. The two copies had already drifted, and this also removes the internal org team allowlist from this public repo. Fetching uses the samelaunchdarklyorg token the membership check already requires, and fails open (treat as engineer) when the skill can't be fetched.Pairs with https://github.com/launchdarkly/gonfalon/pull/67192 — merge that first so the canonical skill file exists on gonfalon
main.Testing approaches
gh apicommand returns the new skill file from the gonfalon branchFeature flags
N/A — documentation-only change.
Note
Low Risk
Documentation-only change to agent guidance; no runtime code or component behavior in LaunchPad is modified.
Overview
AGENTS.mdno longer documents the inline engineer-team allowlist and bash membership lookup for the non-engineer scope warning. Agents are directed to load the canonicalrequester-role-lookupskill from private gonfalon at runtime viagh api(samelaunchdarklyorg token as before).Fail-open guidance now covers unable to fetch the skill (e.g. no org token) or an inconclusive lookup, not only per-team API errors. Complexity sizing and out-of-scope rules in the same section are unchanged.
Reviewed by Cursor Bugbot for commit afa0447. Bugbot is set up for automated code reviews on this repo. Configure here.