Skip to content

docs(agents): fetch canonical requester-role-lookup from gonfalon#1949

Merged
hsadhvani merged 1 commit into
mainfrom
hsadhvani/docs/canonical-role-lookup
Jul 15, 2026
Merged

docs(agents): fetch canonical requester-role-lookup from gonfalon#1949
hsadhvani merged 1 commit into
mainfrom
hsadhvani/docs/canonical-role-lookup

Conversation

@hsadhvani

@hsadhvani hsadhvani commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Replaces the inline copy of the non-engineer scope warning's role-lookup section (engineer team allowlist + bash) with a runtime fetch of the canonical requester-role-lookup skill from gonfalon. The two copies had already drifted, and this also removes the internal org team allowlist from this public repo. Fetching uses the same launchdarkly org token the membership check already requires, and fails open (treat as engineer) when the skill can't be fetched.

Pairs with https://github.com/launchdarkly/gonfalon/pull/67192 — merge that first so the canonical skill file exists on gonfalon main.

Testing approaches

  • Verified the canonical-fetch gh api command returns the new skill file from the gonfalon branch

Feature flags

N/A — documentation-only change.


Note

Low Risk
Documentation-only change to agent guidance; no runtime code or component behavior in LaunchPad is modified.

Overview
AGENTS.md no longer documents the inline engineer-team allowlist and bash membership lookup for the non-engineer scope warning. Agents are directed to load the canonical requester-role-lookup skill from private gonfalon at runtime via gh api (same launchdarkly org token as before).

Fail-open guidance now covers unable to fetch the skill (e.g. no org token) or an inconclusive lookup, not only per-team API errors. Complexity sizing and out-of-scope rules in the same section are unchanged.

Reviewed by Cursor Bugbot for commit afa0447. Bugbot is set up for automated code reviews on this repo. Configure here.

@hsadhvani hsadhvani requested a review from a team as a code owner July 15, 2026 18:47
@changeset-bot

changeset-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: afa0447

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsadhvani hsadhvani merged commit 3dc2d17 into main Jul 15, 2026
19 checks passed
@hsadhvani hsadhvani deleted the hsadhvani/docs/canonical-role-lookup branch July 15, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants