Skip to content

ci(vue-sdk): add contract tests#1790

Open
joker23 wants to merge 1 commit into
mainfrom
skz/sdk-2194/migrate-vue-sdk-contract-tests
Open

ci(vue-sdk): add contract tests#1790
joker23 wants to merge 1 commit into
mainfrom
skz/sdk-2194/migrate-vue-sdk-contract-tests

Conversation

@joker23

@joker23 joker23 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

SDK-2194

Adding fdv1 and fdv2 contract tests to vue sdk


Note

Low Risk
Changes are limited to CI and a private contract-test package; production Vue SDK code paths are exercised for compliance, not altered for app behavior.

Overview
Adds LaunchDarkly SDK contract-test coverage for the Vue client SDK by introducing a new @launchdarkly/vue-contract-test-service workspace and wiring it into the vue GitHub Actions workflow.

The contract-test entity is a small Vite Vue app that connects to the harness adapter over WebSocket (TestHarnessWebSocket), creates clients via createClient / client.start(), and implements harness commands (evaluations, identify/track/flush, flag-change listeners) in ClientEntity, including mapping harness SDK config (endpoints, data system / connection modes, events, tags, hooks) onto client options.

CI builds the SDK and entity, starts the adapter and static app (port 5173), opens the app in headless Playwright, then runs the shared contract-tests action for FDv1 and FDv2 (version: v3), with skip lists for known gaps (streaming REPORT cases and tag-header edge cases). Root package.json registers the new workspace.

Reviewed by Cursor Bugbot for commit ace72f4. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26365 bytes
Compressed size limit: 29000
Uncompressed size: 129044 bytes

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 38747 bytes
Compressed size limit: 39000
Uncompressed size: 212249 bytes

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179504 bytes
Compressed size limit: 200000
Uncompressed size: 831427 bytes

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 32027 bytes
Compressed size limit: 34000
Uncompressed size: 114248 bytes

@joker23 joker23 force-pushed the skz/sdk-2194/migrate-vue-sdk-contract-tests branch from b376ba6 to fcdf04a Compare July 7, 2026 16:17
@joker23 joker23 force-pushed the skz/sdk-2194/migrate-vue-sdk-contract-tests branch from fcdf04a to ace72f4 Compare July 7, 2026 17:10
@joker23 joker23 marked this pull request as ready for review July 7, 2026 18:07
@joker23 joker23 requested a review from a team as a code owner July 7, 2026 18:07

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant