fix: skip comment logic was backwards - #249
Open
jazanne wants to merge 1 commit into
Open
Conversation
erangeles
approved these changes
Aug 19, 2026
Contributor
Author
|
just wanted to bump this for release :) thanks for review @erangeles |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I introduced the wrong logic for skip comment in #234
Note
Overview
Corrects a logic inversion in
main.gofor theskip-commentconfig (INPUT_SKIP-COMMENT).When
config.SkipCommentis true, the action now logs that comment creation is skipped and does not callpostGithubComment. When it is false, it posts or updates the comment as before. The previous!config.SkipCommentbranch had the opposite behavior relative to the log message and intended option semantics.Reviewed by Cursor Bugbot for commit f927d77. Bugbot is set up for automated code reviews on this repo. Configure here.