feat(experiments): adopt the observability hypothesis skill, with read-only tool use - #160
Open
mabramowitz-pixel wants to merge 2 commits into
Conversation
…y version Replaces the conversational hypothesis-builder skill body with the experiment-hypothesis skill from launchdarkly/observability (ai/autofix/vega-plugin/skills/experiment-hypothesis/SKILL.md @ bcb2e82c, 2026-07-31), which is the version driving the in-product experiment builder's hypothesis assist. Body is verbatim from observability. Frontmatter is adapted to satisfy this repo's validator: name matches the skill directory, description is a single-line string rather than a folded scalar, and compatibility reflects that the skill needs no tools. Catalog regenerated and README row updated. references/diagnostic-tree.md is removed because the new body references no support files. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…keys The observability copy of this skill is JSON-only with no tool access, because gonfalon calls it as a single-shot prompt. In ai-tooling the skill runs in an agent, so it can check what already exists before answering. - Permits read-only lookups (get-flag, list-flags, get-metric, list-metrics, get-project, get-environment) and names the forbidden write prefixes explicitly. Lookups inform matches only; they never change routing or component scoring, and are skipped for the junk and aa routes. - Adds an optional matches object to the response contract carrying flagKey, metricKey, and confidence (exact | likely), populated only from tool results and omitted when nothing matched. - Final message is still JSON and nothing else. This is an intentional divergence from the observability copy; the provenance comment now records what to re-sync and what to keep. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit b38bdcb. Configure here.
| Lookups inform the `matches` object only. They never change routing or component | ||
| scoring: an unmatched metric name is still a described outcome, and a matched one | ||
| does not turn a missing measurement into a present one. Skip lookups entirely for | ||
| the `junk` and `aa` routes. |
There was a problem hiding this comment.
Contradictory lookup wording rules
Medium Severity
The new tool-use section tells the model to prefer customer metric wording from lookups, but the same section and response contract also say lookups may only populate matches and must not change the hypothesis sentence. Those instructions conflict, so the model can either rewrite measurement text from lookup results or ignore the wording guidance inconsistently.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit b38bdcb. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What
Replaces the body of
skills/experiments/launchdarkly-experiment-hypothesis-builder/SKILL.mdwith theexperiment-hypothesisskill fromlaunchdarkly/observability, taken fromai/autofix/vega-plugin/skills/experiment-hypothesis/SKILL.mdatbcb2e82c(2026-07-31, observability #1610).That path is the source of truth in observability.
backend/prompts/experiment-hypothesis-skill.mdis generated from it bygo generateand carries a DO NOT EDIT header, so it is not a separate version.Why
The observability copy is the version driving the in-product experiment builder's hypothesis assist, and it is where recent fixes have been landing.
What changed
namematches the skill directory,descriptionis a single-line string rather than a folded scalar (normalize_valuerejects>), andcompatibilityreflects that the skill needs no tools.0.2.0;skills.jsonregenerated withscripts/generate_catalog.py; README row updated.references/diagnostic-tree.mdremoved, since the new body references no support files.CI checks pass locally:
validate_skills.py,generate_catalog.py --check, and the unit tests.Reviewer notes
This is a contract change, not a refresh. The previous skill was a conversational advisory skill with a 9-step workflow, read-only MCP lookups, and a handoff payload to
launchdarkly-experiment-setup. The observability version is a JSON-only prompt with no tool use, entered viaexperiment_hypothesis_builder_assist. Anything expecting the old handoff payload will need updating.Two consequences worth confirming before merge:
launchdarkly-experiment-hypothesis-buildername. If the catalog should instead carry the observability nameexperiment-hypothesis, that is a directory rename plus catalog and README updates.🤖 Generated with Claude Code
Note
Overview
Replaces the
launchdarkly-experiment-hypothesis-builderskill body with the observabilityexperiment-hypothesisprompt (verbatim sync, with provenance comment). The skill is no longer a multi-step conversational coach with MCP lookups and a handoff payload tolaunchdarkly-experiment-setup.It now targets the in-product experiment hypothesis assist (
experiment_hypothesis_builder_assist): one user text in, JSON only out (route,components,hypothesiswith{{hole}}syntax,measurements). Routing covers A/A, junk, rewrite, and scaffold; rubric is Change / Measurement / Rationale with semantic-validity and injection-handling rules.Catalog/metadata: version 0.2.0,
skills.jsonand README descriptions updated; compatibility is no tools / JSON-only. Removesreferences/diagnostic-tree.md(unused by the new body).Reviewed by Cursor Bugbot for commit c93ac34. Bugbot is set up for automated code reviews on this repo. Configure here.
Update: read-only tool use (second commit)
The observability copy is JSON-only with no tool access, because gonfalon calls it as a single-shot prompt. In ai-tooling the skill runs in an agent, so it now checks what already exists before answering.
get-flag,list-flags,get-metric,list-metrics,get-project,get-environment, and names the forbidden write prefixes (create-,update-,toggle-,start-,delete-) explicitly.matchesobject only. They never change routing or component scoring, and are skipped for thejunkandaaroutes.matchesobject:flagKey,metricKey,confidence(exact|likely). Populated only from tool results, omitted when nothing matched.schema_versionstays1since the addition is optional.This is a deliberate divergence from the observability copy, so the two files are no longer byte-comparable. The provenance comment in the skill records what to re-sync from observability (rubric, routing, hole rules) and what to keep (tool use,
matches). A consumer that wants the resolved keys needs to read the new field; one that ignores unknown keys is unaffected.