sqlx-postgres: Make PgNotification struct clone#4228
Merged
abonander merged 1 commit intolaunchbadge:mainfrom Apr 10, 2026
Merged
sqlx-postgres: Make PgNotification struct clone#4228abonander merged 1 commit intolaunchbadge:mainfrom
PgNotification struct clone#4228abonander merged 1 commit intolaunchbadge:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a rest endpoint that does SSE (Server Sent Events) where I listen on a Postgres channel on a notification to look for new rows in a table. I multiplex the
PgListenerthrough a tokio broadcast channel to reuse the same connection for multiple requests. For this thePgNotificationstruct needs to beClone.There is no reason I see why it shouldn't be,
Bytesis designed to be cloned.Does your PR solve an issue?
No, the authors of #303 though thought it was related.
Is this a breaking change?
No, I think this should be fine (no negative trait impls yet).