test: stabilize maintenance view toggle E2E - #206
Open
cursor[bot] wants to merge 3 commits into
Open
Conversation
Co-authored-by: Ryota Murakami <dojce1048@gmail.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
- Coverage 71.19% 70.39% -0.81%
==========================================
Files 171 171
Lines 4742 4732 -10
Branches 1239 1265 +26
==========================================
- Hits 3376 3331 -45
- Misses 1347 1382 +35
Partials 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🧪 E2E Coverage Report (Sharded: 12 parallel jobs)
📊 Full report available in workflow artifacts |
ryota-murakami
marked this pull request as ready for review
July 17, 2026 01:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the CI flake in the maintenance grid/list parity test caused by both animated layouts briefly remaining mounted.
Changes
Testing
pnpm lintpnpm typecheckpnpm test(1,377 passed)pnpm build(using committed.env.testvalues)pnpm exec playwright test --reporter=list— local E2E is blocked because this cloud image does not include Docker for Supabase.pnpm e2e:parallel— attempted; blocked by the same missing Docker/Supabase prerequisite.Screenshots or Recordings
Not applicable; test-only synchronization change.
Checklist
CONTRIBUTING.mdNote
Low Risk
Changes are limited to E2E specs and routine dependency patch/minor upgrades with no application logic changes.
Overview
Stabilizes maintenance E2E around animated grid/list transitions and tightens the comment Escape flow.
The grid/list parity test now counts cards only inside the active layout (
main .grid.gap-6vsmain .mx-auto > .space-y-2), waits until the grid container is detached after switching to list, and asserts parity with Playwright’s retryingtoHaveCountinstead of comparing raw counts while both layouts might still be mounted.The maintenance comment Escape test is rewritten as a deterministic Arrange/Act/Assert case: it clicks either empty or existing comment UI, presses Escape after typing, and asserts the inline editor closes without persisting the unsaved text (no longer gated on empty-state-only).
Also bumps many
package.jsondependencies (Next, Radix, Storybook, Vitest, MSW, Tailwind, etc.) and updatespublic/mockServiceWorker.jsfor MSW 2.15.0.Reviewed by Cursor Bugbot for commit e6de773. Bugbot is set up for automated code reviews on this repo. Configure here.