Skip to content

test(e2e): isolate maintenance comment state - #205

Open
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/ci-failure-edaa
Open

test(e2e): isolate maintenance comment state#205
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/ci-failure-edaa

Conversation

@cursor

@cursor cursor Bot commented Jul 16, 2026

Copy link
Copy Markdown

Summary

Fix the flaky maintenance inline-comment E2E test that caused shard 9 and the downstream report job to fail on PR #204.

Changes

  • Reset maintenance rows and their ProjectInfo records to exact seed state before each inline-comment test
  • Remove count-based conditional paths that allowed Enter and Escape tests to pass without exercising their behavior
  • Assert deterministic empty-state, save, and cancel outcomes

Testing

  • pnpm lint
  • pnpm typecheck
  • pnpm test (1,377 passed)
  • pnpm build (using committed .env.test values)
  • pnpm e2e:parallel (blocked because this cloud environment has no Docker/local Supabase)

Screenshots or Recordings

Not applicable; test-isolation change only.

Checklist

  • I read CONTRIBUTING.md (file is not present in this repository)
  • I updated documentation if needed (not needed)
  • I added or updated tests if needed
Open in Web View Automation 

Note

Low Risk
Changes are test isolation, a test-only DB helper, and routine dependency bumps—no production app logic changes.

Overview
Addresses flaky maintenance inline-comment E2E failures by restoring deterministic DB state before each run in the comment-edit suite.

resetMaintenanceItems now wipes projectinfo rows tied to both maintenance seed IDs (so comments saved on old-project by earlier tests are cleared), then re-upserts only maintenance-1’s ProjectInfo to match seed.sql—leaving old-project without ProjectInfo and an empty comment UI. The inline-comment beforeEach calls this helper before navigation.

Enter and Escape comment tests no longer branch on emptyState.count(); they require the empty state on old-project and use Arrange/Act/Assert so the flows always run.

package.json bumps many production and dev dependencies (Next, Radix, Plate, Storybook, Vitest, MSW, etc.); public/mockServiceWorker.js updates for MSW 2.15.0.

Reviewed by Cursor Bugbot for commit c9d06b2. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
gitbox Ready Ready Preview, Comment Jul 16, 2026 1:21pm

Request Review

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.39%. Comparing base (4603e4f) to head (c9d06b2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   71.19%   70.39%   -0.81%     
==========================================
  Files         171      171              
  Lines        4742     4732      -10     
  Branches     1239     1265      +26     
==========================================
- Hits         3376     3331      -45     
- Misses       1347     1382      +35     
  Partials       19       19              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown

🧪 E2E Coverage Report (Sharded: 12 parallel jobs)

Metric Coverage
Lines 93.21%
Functions 21.01%
Branches 17.49%
Statements 30.65%

📊 Full report available in workflow artifacts

@ryota-murakami
ryota-murakami marked this pull request as ready for review July 17, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants