feat(skills): proactive whiteboard discovery when creating documents#369
feat(skills): proactive whiteboard discovery when creating documents#369yoho-dd wants to merge 3 commits intolarksuite:mainfrom
Conversation
Users rarely mention "画板" explicitly, but their document topics (architecture, workflows, org charts, timelines, etc.) naturally call for visual diagrams. This change makes the AI proactively identify such content and create whiteboards without waiting for the user to ask. - lark-doc/SKILL.md: add whiteboard demand discovery section with semantic-to-diagram-type mapping table - lark-doc-create.md: add "主动画板" writing principle and scene entry - lark-whiteboard/SKILL.md: rewrite description from tool-centric to intent-centric, clarify boundary with lark-doc Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdded documentation guiding proactive insertion of blank whiteboards for semantically structured document content, defined semantic→whiteboard-type mappings, specified control flow to pass Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant DocSkill as lark-doc
participant Docs as DocsService
participant WBSkill as lark-whiteboard
User->>DocSkill: create/update document with structured content
DocSkill->>Docs: `docs +create` / `docs +update` (insert `<whiteboard type="blank">`)
Docs-->>DocSkill: response (includes `data.board_tokens`)
DocSkill->>WBSkill: handoff with `board_tokens`
WBSkill->>Docs: perform edits on whiteboard using tokens
WBSkill-->>User: updated whiteboard embedded in document
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThis PR adds proactive whiteboard discovery to the Confidence Score: 5/5Safe to merge; changes are documentation/instruction-only with no runtime code paths. All remaining findings are P2. The only new issue is a test-plan/exclusion-list inconsistency introduced by the last fix commit — the behavior itself may still be acceptable depending on how the LLM classifies meeting notes. The previously flagged board_tokens gap was addressed in an earlier fix commit. skills/lark-doc/SKILL.md — verify the 不适用 exclusion list matches the PR's stated test-plan expectations.
|
| Filename | Overview |
|---|---|
| skills/lark-doc/SKILL.md | Adds "画板需求挖掘(主动识别)" section with semantic→whiteboard-type mapping table and execution flow; the create-scenario path still leaves an implicit gap in how board_tokens are retrieved after docs +create (addressed separately in previous review). |
| skills/lark-doc/references/lark-doc-create.md | Adds "主动画板" writing principle and a whiteboard row to the scene quick-reference table; changes are consistent with SKILL.md additions. |
| skills/lark-whiteboard/SKILL.md | Description updated from tool-centric ("用户要求绘制图表") to intent-centric ("用户需要可视化表达结构化信息"), with an added line clarifying that lark-doc leads when the primary intent is document creation. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User requests document creation] --> B{Analyze document topic}
B -->|Architecture / Workflow / Org / Timeline / Causal / Compare / etc.| C[Whiteboard needed]
B -->|Pure text log / Data-heavy / User says text-only| D[No whiteboard]
C --> E{Create or Edit scenario?}
E -->|Create| F["docs +create\n(include whiteboard placeholder in markdown)"]
E -->|Edit| G["docs +update --mode append\n(insert whiteboard placeholder)"]
F --> H["docs +fetch or docs +update\nto retrieve board_tokens"]
G --> I["Read data.board_tokens\nfrom docs +update response"]
H --> J[Switch to lark-whiteboard skill\nto draw the diagram]
I --> J
D --> K[Create document with text only]
Reviews (3): Last reviewed commit: "fix: remove meeting notes and weekly rep..." | Re-trigger Greptile
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/lark-doc/references/lark-doc-create.md`:
- Line 71: Update the “主动画板” proactive rule in lark-doc-create.md to include
explicit do-not-insert exceptions so it only triggers when appropriate: when
inserting lark-whiteboard, add a guard clause that skips insertion if the user
explicitly requests text-only output or dense tabular content (mirror the guard
language used in skills/lark-doc/SKILL.md), and apply the same change to the
other occurrence referenced (around line 637); specifically update the “主动画板”
rule text to mention the exceptions (“用户明确要求仅文本” / “密集表格内容不插入画板”) so create
flows won’t over-trigger.
In `@skills/lark-doc/SKILL.md`:
- Line 148: Update the execution step that currently lists only "docs +create"
to also include "docs +update" so edit scenarios route correctly; specifically
change the sentence referencing `docs +create` → taking `board_tokens` and
opening `lark-whiteboard` to read/handle both `docs +create` and `docs +update`
(so edits invoke the same `board_tokens` → `lark-whiteboard` flow described in
SKILL.md).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: bfcd7d31-c4f0-4f88-8f64-9816ef0167b1
📒 Files selected for processing (3)
skills/lark-doc/SKILL.mdskills/lark-doc/references/lark-doc-create.mdskills/lark-whiteboard/SKILL.md
- Execution flow: mention both docs +create and docs +update, clarify board_tokens comes from docs +update response - Add guard clauses to proactive whiteboard rules (skip when user explicitly wants text-only or content suits tables better) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Tip: Greploop — Automatically fix all review issues by running Use the Greptile plugin for Claude Code to query reviews, search comments, and manage custom context directly from your terminal. |
Meeting notes and weekly reports can benefit from whiteboards (e.g., timeline of action items, discussion flow). Only exclude pure text logs/memos and data-dense tabular content. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
Summary
用户创建文档时很少主动提及"画板",但文档主题(架构设计、流程说明、组织关系等)天然需要可视化表达。本 PR 让 AI 在创建文档时主动识别这类内容并联动画板,无需等待用户指定。
Changes
docs +create和docs +update两种场景)和不适用场景Test Plan
npx skills add ./skills -g -y安装成功Related Issues
Summary by CodeRabbit
New Features
Documentation