Skip to content

docs: document milvus tls environment variables#779

Open
amr-sheriff wants to merge 1 commit into
langgenius:mainfrom
amr-sheriff:docs/milvus-tls-env-vars
Open

docs: document milvus tls environment variables#779
amr-sheriff wants to merge 1 commit into
langgenius:mainfrom
amr-sheriff:docs/milvus-tls-env-vars

Conversation

@amr-sheriff
Copy link
Copy Markdown

Summary

Documents the three new environment variables introduced in PR 36265

Variable Purpose
MILVUS_SECURE Enable one-way TLS to Milvus.
MILVUS_SERVER_PEM_PATH Path to the Milvus server certificate (PEM).
MILVUS_SERVER_NAME TLS SNI / server name to verify against the certificate.

Updated in all three locales (en/, ja/, zh/).

@amr-sheriff amr-sheriff requested a review from RiskeyL as a code owner May 17, 2026 07:31
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels May 17, 2026
@RiskeyL
Copy link
Copy Markdown
Contributor

RiskeyL commented May 27, 2026

@amr-sheriff Thanks for catching the new Milvus TLS options and writing these up.

Before we merge, there's one upstream step. Our docs site treats the .env.example files in langgenius/dify as the source of truth for self-host variables. MILVUS_SECURE, MILVUS_SERVER_PEM_PATH, and MILVUS_SERVER_NAME were added to the Pydantic config in #36265 but aren't in any .env.example yet, so for now they live only in code.

Since you're closest to the original change, would you mind opening a quick follow-up PR on langgenius/dify to surface the three in the appropriate .env.example? You'll know best where they fit alongside the existing Milvus vars.

One heads-up on timing: the docs track released versions, so I'll merge this once the upstream change has both landed and shipped in a Dify release, not just merged to main. Link the upstream PR back here and I'll keep this one open to track it. Thanks again for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants