You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@amr-sheriff Thanks for catching the new Milvus TLS options and writing these up.
Before we merge, there's one upstream step. Our docs site treats the .env.example files in langgenius/dify as the source of truth for self-host variables. MILVUS_SECURE, MILVUS_SERVER_PEM_PATH, and MILVUS_SERVER_NAME were added to the Pydantic config in #36265 but aren't in any .env.example yet, so for now they live only in code.
Since you're closest to the original change, would you mind opening a quick follow-up PR on langgenius/dify to surface the three in the appropriate .env.example? You'll know best where they fit alongside the existing Milvus vars.
One heads-up on timing: the docs track released versions, so I'll merge this once the upstream change has both landed and shipped in a Dify release, not just merged to main. Link the upstream PR back here and I'll keep this one open to track it. Thanks again for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
documentationImprovements or additions to documentationsize:XSThis PR changes 0-9 lines, ignoring generated files.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the three new environment variables introduced in PR 36265
MILVUS_SECUREMILVUS_SERVER_PEM_PATHMILVUS_SERVER_NAMEUpdated in all three locales (
en/,ja/,zh/).