Skip to content

feat(api): update API spec from langfuse/langfuse 446fe55#1725

Open
langfuse-bot wants to merge 1 commit into
mainfrom
api-spec-bot-446fe55
Open

feat(api): update API spec from langfuse/langfuse 446fe55#1725
langfuse-bot wants to merge 1 commit into
mainfrom
api-spec-bot-446fe55

Conversation

@langfuse-bot

@langfuse-bot langfuse-bot commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Greptile Summary

This is an auto-generated API spec update (Fern from langfuse/langfuse commit 446fe55) that adds a new running state to BlobStorageSyncStatus and tightens the export_start_date docstring across clients.

  • blob_storage_sync_status.py: adds RUNNING = \"running\" enum member and inserts a new running parameter into the visit() method between idle and queued, which is a breaking change for all existing callers of visit().
  • client.py, raw_client.py, create_blob_storage_integration_request.py: docstring-only additions noting that export_start_date must not be in the future (with a 27-hour timezone tolerance).

Confidence Score: 4/5

Safe to merge with awareness: the docstring and enum additions are clean, but inserting running into the visit() signature is a breaking change for any downstream code that already calls .visit().

Three of the four changed files are docstring-only and pose no risk. The enum file introduces a new RUNNING state correctly, but inserting its running callable between idle and queued in visit() breaks every existing call site — keyword callers get a TypeError at runtime, positional callers silently invoke the wrong branch. This is expected from an auto-generated Fern client whenever a new enum variant is added, but SDK consumers must update all visit() call sites before upgrading.

langfuse/api/blob_storage_integrations/types/blob_storage_sync_status.py — the visit() method's new required running parameter is the only change that could impact existing users.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[BlobStorageSyncStatus] --> B{Current Value}
    B -->|idle| C[idle handler]
    B -->|running| D[running handler NEW]
    B -->|queued| E[queued handler]
    B -->|up_to_date| F[up_to_date handler]
    B -->|disabled| G[disabled handler]
    B -->|error| H[error handler]

    subgraph "visit() parameter order"
        P1[1: idle]
        P2[2: running NEW - inserted here]
        P3[3: queued]
        P4[4: up_to_date]
        P5[5: disabled]
        P6[6: error]
    end
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[BlobStorageSyncStatus] --> B{Current Value}
    B -->|idle| C[idle handler]
    B -->|running| D[running handler NEW]
    B -->|queued| E[queued handler]
    B -->|up_to_date| F[up_to_date handler]
    B -->|disabled| G[disabled handler]
    B -->|error| H[error handler]

    subgraph "visit() parameter order"
        P1[1: idle]
        P2[2: running NEW - inserted here]
        P3[3: queued]
        P4[4: up_to_date]
        P5[5: disabled]
        P6[6: error]
    end
Loading
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
langfuse/api/blob_storage_integrations/types/blob_storage_sync_status.py:32-52
**Breaking change in `visit()` signature**

The new `running` parameter is inserted as the second positional argument — between `idle` and `queued`. Any existing caller using keyword arguments will get a `TypeError` at runtime because `running` is now required. Any caller using positional arguments is even worse off: it will silently dispatch to the wrong handlers (the old second positional arg, `queued`, is now treated as `running`, and every subsequent handler is shifted by one).

Since this file is auto-generated from the API spec, the addition is intentional, but SDK consumers who call `.visit()` today will need to update every call site before upgrading.

Reviews (1): Last reviewed commit: "feat(api): update API spec from langfuse..." | Re-trigger Greptile

@github-actions

Copy link
Copy Markdown

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, auto-generated API spec update adding a RUNNING sync status and docstring clarifications.

Extended reasoning...

Overview

This PR is an auto-generated update from the Fern-generated API client (langfuse/api/blob_storage_integrations/). It adds a new RUNNING enum value to BlobStorageSyncStatus and updates docstrings for export_start_date to mention the 27h future-tolerance constraint. All four modified files are auto-generated (file headers say so).

Security risks

None. This is purely auto-generated client code — docstring updates and an enum value addition. No auth, crypto, or permission paths touched.

Level of scrutiny

Low. These are mechanical regenerations from the upstream OpenAPI spec. The only behavioral surface area is the new RUNNING variant in BlobStorageSyncStatus.visit() (which now requires an extra callable arg), but this code is auto-generated and not used internally by the SDK — it is part of the public API client surface that users opt into.

Other factors

The new enum + visit() signature change is technically a breaking change for any external caller that uses .visit() on this enum, but this matches the upstream API spec and is consistent with how Fern generates these clients. No tests are needed since this is generated code. Matches the established pattern of API-spec regen PRs in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant