fix: skip in-progress Codex turn uploads#17
Open
honki12345 wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
task_completeis writtenWhy
The current behavior can create duplicate Langfuse traces for one Codex turn when the Stop hook reads the rollout before Codex has appended the
task_completemarker. The first hook invocation exports a partial in-progress turn without recording it in the sidecar. A later Stop hook reads the completed turn and exports it again as a new trace.Observed locally with v0.1.0 against a self-hosted Langfuse instance:
metadata['codex.turn_id']appeared with two distinct Langfusetrace_idvaluestask_completeeventtask_completetimestampExample evidence shape:
This is related to the broader Stop hook / sidecar lifecycle concerns in #12, but this PR fixes the specific duplicate-trace path where an in-progress trailing turn is exported before completion.
Verification
pnpm exec prettier --check README.md plugins/tracing/src/trace.ts plugins/tracing/src/sidecar.ts plugins/tracing/test/trace.test.tspnpm run lint:tscpnpm run lint:distpnpm testNote: an earlier parallel run of
pnpm run lint:distandpnpm testfailed becauselint:distcleans/rebuildsplugins/tracing/dist/index.mjswhilehook-command.test.tscopies that file. Running the commands sequentially passes.