feat(encoding): decode generic mini-block offsets - #8042
Draft
Xuanwo wants to merge 1 commit into
Draft
Conversation
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 4 of the generic block compression series. Depends on #8041.
Variable-width mini-block decoding now distinguishes the existing interleaved Flat layout from a generic offset descriptor. The generic path consumes the descriptor-derived zero/one payload plus the values buffer and validates cardinality, zero origin, monotonicity, Arrow signed bounds, and the final value length. The legacy path keeps the existing wire shape while converting malformed buffer panics into contextual errors.
This is reader-only. Production writers still emit the legacy layout for every file version.
Validation:
cargo fmt --allcargo check -p lance-encoding --no-default-features --testscargo check -p lance-encoding --tests --benchescargo test -p lance-encoding compression::testscargo test -p lance-encoding encodings::physicalcargo clippy --all --tests --benches -- -D warningsStack navigation